Change CXFA_TextProvider::GetEmbeddedObj() to take a string view [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Apr 9, 2026, 2:28:19 PM (2 days ago) Apr 9
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Apr 9, 2026, 2:36:09 PM (2 days ago) Apr 9
to Lei Zhang, Tom Sepez, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Apr 9, 2026, 2:49:44 PM (2 days ago) Apr 9
to Lei Zhang, Tom Sepez, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Change CXFA_TextProvider::GetEmbeddedObj() to take a string view
Take a string view instead of a string, since that is what
GetEmbeddedObj() needs internally. In turn, change its only caller to
create a string view and operate on the view instead of modifying the
actual string.
Change-Id: Ie8d2de2ca6e7291d0ade2abcd9d8b9ed7ce1084e
Reviewed-by: Tom Sepez <tse...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Files:
- M xfa/fxfa/cxfa_textparser.cpp
- M xfa/fxfa/cxfa_textprovider.cpp
- M xfa/fxfa/cxfa_textprovider.h
Change size: S
Delta: 3 files changed, 11 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tom Sepez
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages