Replace CHARSET_FLAG macros with CharsetFlags struct [pdfium : main]

2 views
Skip to first unread message

Aryan Krishnan (Gerrit)

unread,
Apr 2, 2026, 5:22:04 PM (9 days ago) Apr 2
to Lei Zhang, Tom Sepez, Andy Phan, Nicolás Peña, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang, Nicolás Peña and Tom Sepez

Aryan Krishnan voted and added 1 comment

Votes added by Aryan Krishnan

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Aryan Krishnan . resolved

Hi guys, refactored the enum in Folderinfo into a struct as well, let me know if it should be edited to something different perhaps. Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
  • Lei Zhang
  • Nicolás Peña
  • Tom Sepez
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Iad4046d423162bdbf60f42f8c1528e53bee76238
Gerrit-Change-Number: 145670
Gerrit-PatchSet: 8
Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Nicolás Peña <n...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Nicolás Peña <n...@chromium.org>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Thu, 02 Apr 2026 21:21:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Aryan Krishnan (Gerrit)

unread,
Apr 2, 2026, 5:22:59 PM (9 days ago) Apr 2
to Pdfium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, Nicolás Peña, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang, Nicolás Peña and Tom Sepez

Aryan Krishnan added 1 comment

File core/fxge/cfx_folderfontinfo_unittest.cpp
Line 38, Patchset 8 (Latest): constexpr CharsetFlags kAnsiTrue = {.ansi = true};
Aryan Krishnan . resolved

Put this in the struct def? wdyt?

Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Nicolás Peña <n...@chromium.org>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Thu, 02 Apr 2026 21:22:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Aryan Krishnan (Gerrit)

unread,
Apr 2, 2026, 5:26:06 PM (9 days ago) Apr 2
to Pdfium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, Nicolás Peña, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang, Nicolás Peña and Tom Sepez

Aryan Krishnan added 1 comment

Patchset-level comments
Aryan Krishnan . resolved

Hi guys, refactored the enum in Folderinfo into a struct as well, let me know if it should be edited to something different perhaps. Thanks!

Aryan Krishnan

defines, not enums mb.

Gerrit-Comment-Date: Thu, 02 Apr 2026 21:26:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aryan Krishnan <aryankr...@gmail.com>
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Apr 7, 2026, 5:25:13 PM (4 days ago) Apr 7
to Aryan Krishnan, Pdfium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, Nicolás Peña, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Aryan Krishnan, Nicolás Peña and Tom Sepez

Lei Zhang added 3 comments

File core/fxge/cfx_folderfontinfo.h
Line 24, Patchset 8 (Latest): bool GB = false;
Lei Zhang . unresolved

Make this consistently lowercase.

Line 19, Patchset 8 (Latest):struct CharsetFlags {
Lei Zhang . unresolved

Can this be part of FontFaceInfo instead of being in the global namespace?

Line 19, Patchset 8 (Latest):struct CharsetFlags {
Lei Zhang . unresolved

Have you considered using fxcrt::Mask?

Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
  • Aryan Krishnan
  • Nicolás Peña
  • Tom Sepez
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: Iad4046d423162bdbf60f42f8c1528e53bee76238
    Gerrit-Change-Number: 145670
    Gerrit-PatchSet: 8
    Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
    Gerrit-Reviewer: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Nicolás Peña <n...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Nicolás Peña <n...@chromium.org>
    Gerrit-Attention: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Attention: Andy Phan <andy...@chromium.org>
    Gerrit-Comment-Date: Tue, 07 Apr 2026 21:25:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages