Make all CFX_GEModule methods static [pdfium : main]

0 views
Skip to first unread message

Tom Sepez (Gerrit)

unread,
Mar 4, 2026, 12:47:16 PM (13 days ago) Mar 4
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

Tom Sepez added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Tom Sepez . resolved

Is this silly?

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: If30160ecd0e3bca310a6ff2215fd6215b55b4a97
Gerrit-Change-Number: 144170
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Wed, 04 Mar 2026 17:47:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
Mar 13, 2026, 5:46:27 PM (4 days ago) Mar 13
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com

Tom Sepez abandoned this change.

View Change

Abandoned meh

Tom Sepez abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages