Roll third_party/harfbuzz/src/ 4fc961392..a243dcb5c (261 commits) [pdfium : main]

[Lei Zhang (Gerrit)]

Attention needed from Andy Phan

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Lei Zhang . resolved

Behdad is super productive!

Open in Gerrit

Related details

Attention is currently required from:

• Andy Phan

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: Id445fc3069ea076b78d1e93b71879dda4e5e24c5

Gerrit-Change-Number: 147170

Gerrit-PatchSet: 5

Gerrit-Owner: Andy Phan <andy...@chromium.org>

Gerrit-Reviewer: Andy Phan <andy...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: pdfium...@luci-project-accounts.iam.gserviceaccount.com <pdfium...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Andy Phan <andy...@chromium.org>

Gerrit-Comment-Date: Thu, 07 May 2026 23:43:39 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Lei Zhang (Gerrit)]

Attention needed from Andy Phan

Lei Zhang removed a vote from this change

Removed Commit-Queue+2 by Lei Zhang <the...@chromium.org>

Open in Gerrit

Related details

Attention is currently required from:

• Andy Phan

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: deleteVote

[pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

Roll third_party/harfbuzz/src/ 4fc961392..a243dcb5c (261 commits)

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/4fc96139259e..a243dcb5c447

Partial roll, since the next commit [1] causes compile errors.

Created with:
  roll-dep third_party/harfbuzz/src

[1]
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+/bd645e5573a435e7cd4dfbce0c0a6f9334b8cfa1

Change-Id: Id445fc3069ea076b78d1e93b71879dda4e5e24c5

Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/147170

Reviewed-by: Lei Zhang <the...@chromium.org>

Commit-Queue: Andy Phan <andy...@chromium.org>

Files:

• M DEPS

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Lei Zhang

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: Id445fc3069ea076b78d1e93b71879dda4e5e24c5

Gerrit-Change-Number: 147170

Gerrit-PatchSet: 6

Gerrit-Owner: Andy Phan <andy...@chromium.org>

Gerrit-Reviewer: Andy Phan <andy...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-Reviewer: pdfium...@luci-project-accounts.iam.gserviceaccount.com <pdfium...@luci-project-accounts.iam.gserviceaccount.com>