Clean up CPVT_VariableText [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Jun 24, 2026, 1:52:34 PM (16 hours ago) Jun 24
to Lei Zhang, Seung Hyun Jin, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Sepez
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 24, 2026, 1:54:08 PM (16 hours ago) Jun 24
to Lei Zhang, Tom Sepez, Seung Hyun Jin, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 24, 2026, 1:55:10 PM (16 hours ago) Jun 24
to Lei Zhang, Tom Sepez, Seung Hyun Jin, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Clean up CPVT_VariableText
- Remove unused GetETPoint().
- Remove GetWordFontSize() which is the same as GetFontSize().
- Make a few methods private.
Change-Id: Ie82f4cc71d032a027b95978314d1d09d6d8d7ca7
Reviewed-by: Tom Sepez <tse...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Files:
- M core/fpdfdoc/cpvt_variabletext.cpp
- M core/fpdfdoc/cpvt_variabletext.h
Change size: S
Delta: 2 files changed, 11 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tom Sepez
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages