Rename `CPDF_TextObject::char_pos_` [pdfium : main]

0 views

Skip to first unread message

Andy Phan (Gerrit)

unread,

Mar 16, 2026, 12:37:53 PM (yesterday) Mar 16

to Lei Zhang, pdfium-...@googlegroups.com

Attention needed from Lei Zhang

Andy Phan voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Mar 16, 2026, 1:46:41 PM (yesterday) Mar 16

to Lei Zhang, Andy Phan, pdfium-...@googlegroups.com

Lei Zhang voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Pdfium LUCI CQ (Gerrit)

unread,

Mar 16, 2026, 2:29:04 PM (yesterday) Mar 16

to Lei Zhang, Andy Phan, pdfium-...@googlegroups.com

Pdfium LUCI CQ submitted the change

Change information

Commit message:

Rename `CPDF_TextObject::char_pos_`

Reanme it to `char_positions_` since it is plural.

Change-Id: I414b0de0deb1a69ae3cdfd28feaf3a0cecc41b32

Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/144850

Reviewed-by: Andy Phan <andy...@chromium.org>

Commit-Queue: Lei Zhang <the...@chromium.org>

Files:

M core/fpdfapi/page/cpdf_textobject.cpp
M core/fpdfapi/page/cpdf_textobject.h

Change size: S

Delta: 2 files changed, 9 insertions(+), 9 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Andy Phan

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages