Move StandardFont enum and utilities to CFX_StandardFont. [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Jun 24, 2026, 3:32:07 PM (14 hours ago) Jun 24
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 24, 2026, 4:13:31 PM (13 hours ago) Jun 24
to Tom Sepez, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Jun 24, 2026, 4:13:52 PM (13 hours ago) Jun 24
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Tom Sepez voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 24, 2026, 5:35:05 PM (12 hours ago) Jun 24
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Move StandardFont enum and utilities to CFX_StandardFont.
This is the first step in a chain breaking the circular dependency
between CFX_FontMapper and CFX_FontMgr. This will allow files in
fpdfapi/ to only know about the standard fonts, and not the
heavier mapper.
-- Introduce GetCanonicalFontName() method to avoid direct access
to an array,
TAG=agy
CONV=a7eb1d9a-c49f-4737-82a1-59c7ae6d9d52
Change-Id: Iebc7993af76b0a2591236ab7d5b2d0f1159bd5be
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Tom Sepez <tse...@chromium.org>
Files:
- M core/fpdfapi/font/cpdf_font.cpp
- M core/fpdfapi/font/cpdf_fontglobals.cpp
- M core/fpdfapi/font/cpdf_fontglobals.h
- M core/fpdfapi/font/cpdf_stockfontarray.cpp
- M core/fpdfapi/font/cpdf_stockfontarray.h
- M core/fpdfapi/font/cpdf_type1font.cpp
- M core/fpdfapi/font/cpdf_type1font.h
- M core/fpdfapi/page/cpdf_docpagedata.cpp
- M core/fpdfdoc/cpdf_bafontmap.cpp
- M core/fxge/BUILD.gn
- M core/fxge/cfx_fontmapper.cpp
- M core/fxge/cfx_fontmapper.h
- M core/fxge/cfx_fontmapper_unittest.cpp
- M core/fxge/cfx_fontmgr.cpp
- A core/fxge/cfx_standardfont.cpp
- A core/fxge/cfx_standardfont.h
- A core/fxge/cfx_standardfont_unittest.cpp
Change size: L
Delta: 17 files changed, 383 insertions(+), 237 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages