Move StandardFont enum and utilities to CFX_StandardFont. [pdfium : main]

0 views
Skip to first unread message

Tom Sepez (Gerrit)

unread,
Jun 24, 2026, 3:32:07 PM (14 hours ago) Jun 24
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Iebc7993af76b0a2591236ab7d5b2d0f1159bd5be
Gerrit-Change-Number: 150750
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Wed, 24 Jun 2026 19:32:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jun 24, 2026, 4:13:31 PM (13 hours ago) Jun 24
to Tom Sepez, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Tom Sepez

Lei Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Iebc7993af76b0a2591236ab7d5b2d0f1159bd5be
Gerrit-Change-Number: 150750
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Wed, 24 Jun 2026 20:13:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
Jun 24, 2026, 4:13:52 PM (13 hours ago) Jun 24
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Tom Sepez voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Iebc7993af76b0a2591236ab7d5b2d0f1159bd5be
Gerrit-Change-Number: 150750
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Wed, 24 Jun 2026 20:13:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Jun 24, 2026, 5:35:05 PM (12 hours ago) Jun 24
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Move StandardFont enum and utilities to CFX_StandardFont.

This is the first step in a chain breaking the circular dependency
between CFX_FontMapper and CFX_FontMgr. This will allow files in
fpdfapi/ to only know about the standard fonts, and not the
heavier mapper.

-- Introduce GetCanonicalFontName() method to avoid direct access
to an array,

TAG=agy
CONV=a7eb1d9a-c49f-4737-82a1-59c7ae6d9d52
Change-Id: Iebc7993af76b0a2591236ab7d5b2d0f1159bd5be
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Tom Sepez <tse...@chromium.org>
Files:
  • M core/fpdfapi/font/cpdf_font.cpp
  • M core/fpdfapi/font/cpdf_fontglobals.cpp
  • M core/fpdfapi/font/cpdf_fontglobals.h
  • M core/fpdfapi/font/cpdf_stockfontarray.cpp
  • M core/fpdfapi/font/cpdf_stockfontarray.h
  • M core/fpdfapi/font/cpdf_type1font.cpp
  • M core/fpdfapi/font/cpdf_type1font.h
  • M core/fpdfapi/page/cpdf_docpagedata.cpp
  • M core/fpdfdoc/cpdf_bafontmap.cpp
  • M core/fxge/BUILD.gn
  • M core/fxge/cfx_fontmapper.cpp
  • M core/fxge/cfx_fontmapper.h
  • M core/fxge/cfx_fontmapper_unittest.cpp
  • M core/fxge/cfx_fontmgr.cpp
  • A core/fxge/cfx_standardfont.cpp
  • A core/fxge/cfx_standardfont.h
  • A core/fxge/cfx_standardfont_unittest.cpp
Change size: L
Delta: 17 files changed, 383 insertions(+), 237 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Lei Zhang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Iebc7993af76b0a2591236ab7d5b2d0f1159bd5be
Gerrit-Change-Number: 150750
Gerrit-PatchSet: 5
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages