Always parse fonts with skia when fontations is enabled. [pdfium : main]
Tom Sepez (Gerrit)
Tom Sepez added 2 comments![]( "Open in Gerrit")
#if defined(PDF_ENABLE_FONTATIONS)NOTE: would like to do this for PDF_USE_SKIA, but profiling embedder_tests shows that only about 40% of fonts are loaded this way later on. Too much?
SkTypeface* CFX_Face::GetOrCreateSkTypeface() {NOTE: at which point this would become a simple getter.
Related details
- Lei Zhang
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Lei Zhang added 2 comments![]( "Open in Gerrit")
#if defined(PDF_ENABLE_FONTATIONS)NOTE: would like to do this for PDF_USE_SKIA, but profiling embedder_tests shows that only about 40% of fonts are loaded this way later on. Too much?
Can this be guarded by a run-time check rather than compile-time?
return result; // Private ctor.Comment is in the wrong place.
Related details
- Tom Sepez
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Tom Sepez voted and added 3 comments![]( "Open in Gerrit")
Votes added by Tom Sepez
| Commit-Queue | +1 |
3 comments
#if defined(PDF_ENABLE_FONTATIONS)Lei ZhangNOTE: would like to do this for PDF_USE_SKIA, but profiling embedder_tests shows that only about 40% of fonts are loaded this way later on. Too much?
Can this be guarded by a run-time check rather than compile-time?
Probably, but yet another initialization parameter. I'll leave it for fontations at the moment.
Comment is in the wrong place.
Done
NOTE: at which point this would become a simple getter.
- Lei Zhang
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Lei Zhang added 1 comment![]( "Open in Gerrit")
#if defined(PDF_ENABLE_FONTATIONS)Lei ZhangNOTE: would like to do this for PDF_USE_SKIA, but profiling embedder_tests shows that only about 40% of fonts are loaded this way later on. Too much?
Tom SepezCan this be guarded by a run-time check rather than compile-time?
Probably, but yet another initialization parameter. I'll leave it for fontations at the moment.
Isn't it just a `CFX_FontMgr::font_backend_` query, exposed via CFX_GEModule?
Related details
- Tom Sepez
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Tom Sepez added 1 comment![]( "Open in Gerrit")
#if defined(PDF_ENABLE_FONTATIONS)Lei ZhangNOTE: would like to do this for PDF_USE_SKIA, but profiling embedder_tests shows that only about 40% of fonts are loaded this way later on. Too much?
Tom SepezCan this be guarded by a run-time check rather than compile-time?
Lei ZhangProbably, but yet another initialization parameter. I'll leave it for fontations at the moment.
Isn't it just a `CFX_FontMgr::font_backend_` query, exposed via CFX_GEModule?
I'm cheating. I actually want to check that normal skia returns the same things in a follow-on CL. Suggestions?
Related details
- Lei Zhang
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
#if defined(PDF_ENABLE_FONTATIONS)Lei ZhangNOTE: would like to do this for PDF_USE_SKIA, but profiling embedder_tests shows that only about 40% of fonts are loaded this way later on. Too much?
Tom SepezCan this be guarded by a run-time check rather than compile-time?
Lei ZhangProbably, but yet another initialization parameter. I'll leave it for fontations at the moment.
Tom SepezIsn't it just a `CFX_FontMgr::font_backend_` query, exposed via CFX_GEModule?
I'm cheating. I actually want to check that normal skia returns the same things in a follow-on CL. Suggestions?
Maybe write a TODO or have some other reminder to eventually stop cheating?
Related details
- Tom Sepez
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |