Remove EmbedderTest::UnloadPage() call in fpdf_edit_embeddertest.cpp [pdfium : main]
0 views
Skip to first unread message
Andy Phan (Gerrit)
Mar 12, 2026, 6:54:19 PM (5 days ago) Mar 12
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Andy Phan voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Mar 12, 2026, 7:44:53 PM (5 days ago) Mar 12
to Lei Zhang, Andy Phan, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Mar 12, 2026, 8:12:18 PM (5 days ago) Mar 12
to Lei Zhang, Andy Phan, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Remove EmbedderTest::UnloadPage() call in fpdf_edit_embeddertest.cpp
Use EmbedderTest::LoadScopedPage() instead. Also remove an unnecessary
CloseDocument() call.
Bug: 407147676
Change-Id: I4964f2a7a33682738d4d32aec25b97dd18d282c9
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Andy Phan <andy...@chromium.org>
Files:
- M fpdfsdk/fpdf_edit_embeddertest.cpp
Change size: S
Delta: 1 file changed, 4 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andy Phan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages