Abstract AGG behind RenderDeviceDriverIface::Continuation. [pdfium : main]

0 views

Skip to first unread message

Tom Sepez (Gerrit)

unread,

Feb 20, 2026, 7:22:47 PM (2 days ago) Feb 20

to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com

Tom Sepez voted and added 2 comments

Votes added by Tom Sepez

Commit-Queue

2 comments

Commit Message

Line 7, Patchset 1:Abstract AGG behind RenderDeviceDriverIface:Continuation.

Lei Zhang . resolved

Double colon.

Tom Sepez

Done

File core/fxge/renderdevicedriver_iface.h

Line 116, Patchset 1: virtual bool ContinueDIBits(Continuation* handle,

Lei Zhang . resolved

Rename to "continuation" here and in .cpp files.

Tom Sepez

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Pdfium LUCI CQ (Gerrit)

unread,

Feb 20, 2026, 8:25:33 PM (2 days ago) Feb 20

to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com

Pdfium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: core/fxge/renderdevicedriver_iface.h
Insertions: 1, Deletions: 1.

@@ -113,7 +113,7 @@
                                   const CFX_Matrix& matrix,
                                   const FXDIB_ResampleOptions& options,
                                   BlendMode blend_type) = 0;
-  virtual bool ContinueDIBits(Continuation* handle,
+  virtual bool ContinueDIBits(Continuation* continuation,
                               PauseIndicatorIface* pPause);
   virtual bool DrawDeviceText(pdfium::span<const TextCharPos> pCharPos,
                               CFX_Font* font,
```
```
The name of the file: core/fxge/renderdevicedriver_iface.cpp
Insertions: 1, Deletions: 1.

@@ -44,7 +44,7 @@
   return RetainPtr<const CFX_DIBitmap>();
 }
 
-bool RenderDeviceDriverIface::ContinueDIBits(Continuation* handle,
+bool RenderDeviceDriverIface::ContinueDIBits(Continuation* continuation,
                                              PauseIndicatorIface* pPause) {
   return false;
 }
```

Change information

Commit message:

Abstract AGG behind RenderDeviceDriverIface::Continuation.

Although the higher layers didn't necessarily interact with AGG
directly, this abstraction removes some of the impression that they
did, by getting the string 'Agg' out of the names.

Bug: 485984630

Change-Id: Ifa065518fdfe3516aaf40dcf10629074603f6b34

Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/143571

Commit-Queue: Tom Sepez <tse...@chromium.org>

Reviewed-by: Lei Zhang <the...@chromium.org>

Files:

M core/fpdfapi/render/cpdf_imagerenderer.cpp
M core/fpdfapi/render/cpdf_imagerenderer.h
M core/fpdfapi/render/cpdf_renderstatus.cpp
M core/fxge/agg/cfx_agg_devicedriver.cpp
M core/fxge/agg/cfx_agg_devicedriver.h
M core/fxge/agg/cfx_agg_imagerenderer.h
M core/fxge/cfx_renderdevice.cpp
M core/fxge/cfx_renderdevice.h
M core/fxge/renderdevicedriver_iface.cpp
M core/fxge/renderdevicedriver_iface.h
M core/fxge/skia/fx_skia_device.cpp
M core/fxge/win32/cgdi_device_driver.cpp
M core/fxge/win32/cgdi_display_driver.cpp
M core/fxge/win32/cgdi_printer_driver.cpp
M core/fxge/win32/cps_printer_driver.cpp
M core/fxge/win32/ctext_only_printer_driver.cpp
M xfa/fxfa/cxfa_imagerenderer.cpp
M xfa/fxfa/cxfa_imagerenderer.h

Change size: M

Delta: 18 files changed, 35 insertions(+), 38 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Lei Zhang

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages