Groups

pdfium-reviews

Contact owners and managers

1–30 of 20525

0 selected

Aryan Krishnan (Gerrit), Andy Phan (Gerrit)3

2:18 PM

Replace the EM_ADJUST macro with a function [pdfium : main]

Attention needed from Andy Phan, Lei Zhang and Tom Sepez Aryan Krishnan voted and added 2 comments

unread,

Replace the EM_ADJUST macro with a function [pdfium : main]

Attention needed from Andy Phan, Lei Zhang and Tom Sepez Aryan Krishnan voted and added 2 comments

2:18 PM

Aryan Krishnan (Gerrit)2

2:08 PM

Replace EM_ADJUST macro usage with NormalizeFontMetric() [pdfium : main]

Attention needed from Andy Phan, Lei Zhang and Tom Sepez Aryan Krishnan added 1 comment Patchset-

unread,

Replace EM_ADJUST macro usage with NormalizeFontMetric() [pdfium : main]

Attention needed from Andy Phan, Lei Zhang and Tom Sepez Aryan Krishnan added 1 comment Patchset-

2:08 PM

Lei Zhang (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

1:53 PM

Update PDF 1.7 spec references to ISO 32000-1:2008. [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Update PDF 1.7 spec references to ISO 32000-1:2008. [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

1:53 PM

Kuka (Gerrit), … Lei Zhang (Gerrit)22

1:26 PM

Start list rearrangement at requested item [pdfium : main]

Attention needed from Kuka and Tom Sepez Lei Zhang voted and added 1 comment Votes added by Lei Zhang

unread,

Start list rearrangement at requested item [pdfium : main]

Attention needed from Kuka and Tom Sepez Lei Zhang voted and added 1 comment Votes added by Lei Zhang

1:26 PM

Kuka (Gerrit), Lei Zhang (Gerrit)3

11:57 AM

Remove flattened fields from AcroForm [pdfium : main]

Attention needed from Lei Zhang and Tom Sepez Kuka added 7 comments Patchset-level comments File-

unread,

Remove flattened fields from AcroForm [pdfium : main]

Attention needed from Lei Zhang and Tom Sepez Kuka added 7 comments Patchset-level comments File-

11:57 AM

Tom Sepez (Gerrit), Lei Zhang (Gerrit)4

Jun 3

Add span-based I/O wrappers as core/fxcrt/span_io.h [pdfium : main]

Attention needed from Tom Sepez Lei Zhang added 7 comments File core/fxcrt/span_io.h Line 103,

unread,

Add span-based I/O wrappers as core/fxcrt/span_io.h [pdfium : main]

Attention needed from Tom Sepez Lei Zhang added 7 comments File core/fxcrt/span_io.h Line 103,

Jun 3

Aryan Krishnan (Gerrit), Lei Zhang (Gerrit)25

Jun 3

Add simple tests for Brotli compression [pdfium : main]

Attention needed from Andy Phan, Lei Zhang and Tom Sepez Aryan Krishnan voted Commit-Queue+1 Commit-

unread,

Add simple tests for Brotli compression [pdfium : main]

Attention needed from Andy Phan, Lei Zhang and Tom Sepez Aryan Krishnan voted Commit-Queue+1 Commit-

Jun 3

Tom Sepez (Gerrit)

Jun 2

Share manual font table parsing in CFX_FolderFontInfo [pdfium : main]

Attention needed from Lei Zhang Tom Sepez added 5 comments Patchset-level comments File-level comment

unread,

Share manual font table parsing in CFX_FolderFontInfo [pdfium : main]

Attention needed from Lei Zhang Tom Sepez added 5 comments Patchset-level comments File-level comment

Jun 2

Tom Sepez (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jun 2

Fix logic botch in cpdf_nametree.cpp [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Fix logic botch in cpdf_nametree.cpp [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 2

April Kallmeyer (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jun 2

Roll clang+rust [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Roll clang+rust [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 2

April Kallmeyer (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

Jun 2

Roll v8/ 8e10f842e..0c6c73eea (692 commits) [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Roll v8/ 8e10f842e..0c6c73eea (692 commits) [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 2

Aryan Krishnan (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

Jun 2

Replace c-style casts in cfgas_decimal.cpp with static_casts [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Replace c-style casts in cfgas_decimal.cpp with static_casts [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 2

Tom Sepez (Gerrit), Lei Zhang (Gerrit)2

Jun 2

Comment sections of CFX_Face still requiring skrifa conversions. [pdfium : main]

Attention needed from Tom Sepez Lei Zhang voted Code-Review+1 Code-Review +1 Open in Gerrit Related

unread,

Comment sections of CFX_Face still requiring skrifa conversions. [pdfium : main]

Attention needed from Tom Sepez Lei Zhang voted Code-Review+1 Code-Review +1 Open in Gerrit Related

Jun 2

Dominik Röttsches (Gerrit)2

Jun 2

Update OWNERS files for Freetype and Skia [pdfium : main]

Attention needed from Florin Malita and Lei Zhang Dominik Röttsches added 1 comment Patchset-level

unread,

Update OWNERS files for Freetype and Skia [pdfium : main]

Attention needed from Florin Malita and Lei Zhang Dominik Röttsches added 1 comment Patchset-level

Jun 2

Tom Sepez (Gerrit), Lei Zhang (Gerrit)2

Jun 1

fxge: Share manual font table parsing and use in Android [pdfium : main]

Attention needed from Tom Sepez Lei Zhang added 5 comments Patchset-level comments File-level comment

unread,

fxge: Share manual font table parsing and use in Android [pdfium : main]

Attention needed from Tom Sepez Lei Zhang added 5 comments Patchset-level comments File-level comment

Jun 1

April Kallmeyer (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

Jun 1

Roll build, buildtools, libc++, and llvm-libc [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Roll build, buildtools, libc++, and llvm-libc [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 1

Tom Sepez (Gerrit)

Jun 1

Refactor CFX_Face table access and use Skrifa for checks. [pdfium : main]

Attention needed from Lei Zhang New activity on the change Open in Gerrit Related details Attention

unread,

Refactor CFX_Face table access and use Skrifa for checks. [pdfium : main]

Attention needed from Lei Zhang New activity on the change Open in Gerrit Related details Attention

Jun 1

April Kallmeyer (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jun 1

Roll Harfbuzz and icu [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Roll Harfbuzz and icu [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 1

Helmut Januschka (Gerrit), Lei Zhang (Gerrit)2

Jun 1

Replace JBIG2_MIN_SEGMENT_SIZE with a constexpr [pdfium : main]

Attention needed from Aryan Krishnan and Helmut Januschka Lei Zhang voted Code-Review+1 Code-Review +

unread,

Replace JBIG2_MIN_SEGMENT_SIZE with a constexpr [pdfium : main]

Attention needed from Aryan Krishnan and Helmut Januschka Lei Zhang voted Code-Review+1 Code-Review +

Jun 1

Helmut Januschka (Gerrit), Lei Zhang (Gerrit)2

Jun 1

Replace PNG_ERROR_SIZE with a constexpr [pdfium : main]

Attention needed from Aryan Krishnan and Helmut Januschka Lei Zhang voted Code-Review+1 Code-Review +

unread,

Replace PNG_ERROR_SIZE with a constexpr [pdfium : main]

Attention needed from Aryan Krishnan and Helmut Januschka Lei Zhang voted Code-Review+1 Code-Review +

Jun 1

Tom Sepez (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

Jun 1

[Android] Nest font metadata privately in manager [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[Android] Nest font metadata privately in manager [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Jun 1

Aryan Krishnan (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

Jun 1

Roll third_party/brotli/ aaafc7036..143b119f4 (2 commits) [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Roll third_party/brotli/ aaafc7036..143b119f4 (2 commits) [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 1

Aryan Krishnan (Gerrit), Helmut Januschka (Gerrit)4

May 31

Replace JBIG2_MIN_SEGMENT_SIZE with constexpr [pdfium : main]

Attention needed from Helmut Januschka and Lei Zhang Aryan Krishnan added 1 comment Commit Message

unread,

Replace JBIG2_MIN_SEGMENT_SIZE with constexpr [pdfium : main]

Attention needed from Helmut Januschka and Lei Zhang Aryan Krishnan added 1 comment Commit Message

May 31

Aryan Krishnan (Gerrit), Helmut Januschka (Gerrit)3

May 31

Replace PNG_ERROR_SIZE with constexpr [pdfium : main]

Attention needed from Helmut Januschka and Lei Zhang Aryan Krishnan added 1 comment Commit Message

unread,

Replace PNG_ERROR_SIZE with constexpr [pdfium : main]

Attention needed from Helmut Januschka and Lei Zhang Aryan Krishnan added 1 comment Commit Message

May 31

Aryan Krishnan (Gerrit)

May 31

Replace FWL_STATE defines with WidgetState enum and Mask [pdfium : main]

Attention needed from Helmut Januschka Aryan Krishnan added 2 comments Commit Message Line 9,

unread,

Replace FWL_STATE defines with WidgetState enum and Mask [pdfium : main]

Attention needed from Helmut Januschka Aryan Krishnan added 2 comments Commit Message Line 9,

May 31

Helmut Januschka (Gerrit), Aryan Krishnan (Gerrit)2

May 31

Replace FWLTHEME color and capacity defines with constexpr [pdfium : main]

Attention needed from Helmut Januschka Aryan Krishnan added 1 comment Commit Message Line 9, Patchset

unread,

Replace FWLTHEME color and capacity defines with constexpr [pdfium : main]

Attention needed from Helmut Januschka Aryan Krishnan added 1 comment Commit Message Line 9, Patchset

May 31

Aryan Krishnan (Gerrit)

May 31

Replace FXMATH_DECIMAL macros with constexpr in cfgas_decimal.cpp [pdfium : main]

Attention needed from Helmut Januschka Aryan Krishnan added 1 comment Commit Message Line 9, Patchset

unread,

Replace FXMATH_DECIMAL macros with constexpr in cfgas_decimal.cpp [pdfium : main]

Attention needed from Helmut Januschka Aryan Krishnan added 1 comment Commit Message Line 9, Patchset

May 31

Aryan Krishnan (Gerrit)

May 31

Rename FX_LINEBREAKTYPE to LineBreakType [pdfium : main]

Attention needed from Helmut Januschka Aryan Krishnan added 3 comments Commit Message Line 9,

unread,

Rename FX_LINEBREAKTYPE to LineBreakType [pdfium : main]

Attention needed from Helmut Januschka Aryan Krishnan added 3 comments Commit Message Line 9,

May 31

Aryan Krishnan (Gerrit)

May 31

Replace FXFONT_USEEXTERNATTR define with kFontUseExternAttr constexpr [pdfium : main]

Attention needed from Helmut Januschka Aryan Krishnan added 2 comments Commit Message Line 7,

unread,

Replace FXFONT_USEEXTERNATTR define with kFontUseExternAttr constexpr [pdfium : main]

Attention needed from Helmut Januschka Aryan Krishnan added 2 comments Commit Message Line 7,

May 31

Aryan Krishnan (Gerrit)

May 31

Replace FWL_STYLE_WGT defines with WidgetStyle enum and Mask [pdfium : main]

Attention needed from Helmut Januschka Aryan Krishnan added 2 comments Commit Message Line 9,

unread,

Replace FWL_STYLE_WGT defines with WidgetStyle enum and Mask [pdfium : main]

Attention needed from Helmut Januschka Aryan Krishnan added 2 comments Commit Message Line 9,

May 31

Search

Clear search

Close search

Google apps

Main menu