Groups

pdfium-reviews

Contact owners and managers

1–30 of 20179

0 selected

Lei Zhang (Gerrit), Ben Wagner (Gerrit)3

Feb 21

Update expectations for https://skia-review.googlesource.com/1150076 [pdfium_tests : main]

Attention needed from Lei Zhang Ben Wagner added 1 comment Patchset-level comments File-level comment

unread,

Update expectations for https://skia-review.googlesource.com/1150076 [pdfium_tests : main]

Attention needed from Lei Zhang Ben Wagner added 1 comment Patchset-level comments File-level comment

Feb 21

Aryan Krishnan (Gerrit), … Lei Zhang (Gerrit)14

Feb 20

Add tests for bug 474670216 [pdfium : main]

Aryan Krishnan abandoned this change. View Change Abandoned Tests not needed as PDF file sizes are

unread,

Add tests for bug 474670216 [pdfium : main]

Aryan Krishnan abandoned this change. View Change Abandoned Tests not needed as PDF file sizes are

Feb 20

Aryan Krishnan (Gerrit), Tom Sepez (Gerrit)10

Feb 20

Use variadic template for Mask constructor [pdfium : main]

Attention needed from Andy Phan, Lei Zhang and Tom Sepez Aryan Krishnan added 1 comment Patchset-

unread,

Use variadic template for Mask constructor [pdfium : main]

Attention needed from Andy Phan, Lei Zhang and Tom Sepez Aryan Krishnan added 1 comment Patchset-

Feb 20

Andy Phan (Gerrit), … Pdfium LUCI CQ (Gerrit)3

Feb 20

Add a regression test for FPDFTextObj_GetText() and space characters [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 1 is the latest

unread,

Add a regression test for FPDFTextObj_GetText() and space characters [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 1 is the latest

Feb 20

Tom Sepez (Gerrit), … Pdfium LUCI CQ (Gerrit)5

Feb 20

Remove CFX_AggClipRgn from CFX_DIBBase. [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 1 is the latest

unread,

Remove CFX_AggClipRgn from CFX_DIBBase. [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 1 is the latest

Feb 20

Tom Sepez (Gerrit), Pdfium LUCI CQ (Gerrit)2

Feb 20

Abstract AGG behind RenderDeviceDriverIface::Continuation. [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 1 is the latest

unread,

Abstract AGG behind RenderDeviceDriverIface::Continuation. [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 1 is the latest

Feb 20

Andy Phan (Gerrit), Lei Zhang (Gerrit)2

Feb 20

Move and reuse MaybeRemoveSubsettedFontPrefix() [pdfium : main]

Attention needed from Andy Phan Lei Zhang added 1 comment File core/fpdfapi/font/cpdf_simplefont.cpp

unread,

Move and reuse MaybeRemoveSubsettedFontPrefix() [pdfium : main]

Attention needed from Andy Phan Lei Zhang added 1 comment File core/fpdfapi/font/cpdf_simplefont.cpp

Feb 20

Lei Zhang (Gerrit)

Feb 20

Roll third_party/skia/ c497e689b..356c7267f (1 commit) [pdfium : main]

Attention needed from Ben Wagner Lei Zhang added 2 comments Patchset-level comments File-level

unread,

Roll third_party/skia/ c497e689b..356c7267f (1 commit) [pdfium : main]

Attention needed from Ben Wagner Lei Zhang added 2 comments Patchset-level comments File-level

Feb 20

Lei Zhang (Gerrit), … Pdfium LUCI CQ (Gerrit)3

Feb 20

Refactor RemoveSubsettedFontPrefix() and IsStrUpper() [pdfium : main]

Pdfium LUCI CQ submitted the change Change information Commit message: Refactor

unread,

Refactor RemoveSubsettedFontPrefix() and IsStrUpper() [pdfium : main]

Pdfium LUCI CQ submitted the change Change information Commit message: Refactor

Feb 20

Andy Phan (Gerrit), Lei Zhang (Gerrit)4

Feb 20

Move and use MaybeRemoveSubsettedFontPrefix() [pdfium : main]

Attention needed from Andy Phan Lei Zhang added 1 comment Commit Message Line 7, Patchset 2 (Latest):

unread,

Move and use MaybeRemoveSubsettedFontPrefix() [pdfium : main]

Attention needed from Andy Phan Lei Zhang added 1 comment Commit Message Line 7, Patchset 2 (Latest):

Feb 20

Andy Phan (Gerrit), Lei Zhang (Gerrit)6

Feb 20

Add a prefix to font subset name [pdfium : main]

Attention needed from Andy Phan Lei Zhang added 6 comments File core/fpdfapi/edit/cpdf_fontsubsetter.

unread,

Add a prefix to font subset name [pdfium : main]

Attention needed from Andy Phan Lei Zhang added 6 comments File core/fpdfapi/edit/cpdf_fontsubsetter.

Feb 20

Tom Sepez (Gerrit), Lei Zhang (Gerrit)2

Feb 20

Abstract AGG behind RenderDeviceDriverIface:Continuation. [pdfium : main]

Attention needed from Tom Sepez Lei Zhang voted and added 2 comments Votes added by Lei Zhang Code-

unread,

Abstract AGG behind RenderDeviceDriverIface:Continuation. [pdfium : main]

Attention needed from Tom Sepez Lei Zhang voted and added 2 comments Votes added by Lei Zhang Code-

Feb 20

Lei Zhang (Gerrit), … Pdfium LUCI CQ (Gerrit)5

Feb 20

Modernize FX_Random further [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 1 is the latest

unread,

Modernize FX_Random further [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 1 is the latest

Feb 20

Lei Zhang (Gerrit), … Pdfium LUCI CQ (Gerrit)6

Feb 20

Remove MTContext [pdfium : main]

Pdfium LUCI CQ submitted the change Change information Commit message: Remove MTContext MTContext is

unread,

Remove MTContext [pdfium : main]

Pdfium LUCI CQ submitted the change Change information Commit message: Remove MTContext MTContext is

Feb 20

Lei Zhang (Gerrit), … Pdfium LUCI CQ (Gerrit)3

Feb 20

Replace FX_Random_MT_.* functions with FX_Random class [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 12 is the latest

unread,

Replace FX_Random_MT_.* functions with FX_Random class [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 12 is the latest

Feb 20

Andy Phan (Gerrit), … Pdfium LUCI CQ (Gerrit)4

Feb 20

Rename FX_Random_MT_GenerateMT() [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 1 is the latest

unread,

Rename FX_Random_MT_GenerateMT() [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 1 is the latest

Feb 20

Lei Zhang (Gerrit), … Pdfium LUCI CQ (Gerrit)6

Feb 20

Update pixel test for rendering that depends on /ToUnicode [pdfium : main]

Pdfium LUCI CQ submitted the change Change information Commit message: Update pixel test for

unread,

Update pixel test for rendering that depends on /ToUnicode [pdfium : main]

Pdfium LUCI CQ submitted the change Change information Commit message: Update pixel test for

Feb 20

Andy Phan (Gerrit), … Pdfium LUCI CQ (Gerrit)12

Feb 20

Introduce CPDF_FontSubsetter to subset new fonts on PDF save [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 24 is the latest

unread,

Introduce CPDF_FontSubsetter to subset new fonts on PDF save [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 24 is the latest

Feb 20

Lei Zhang (Gerrit), … Pdfium LUCI CQ (Gerrit)3

Feb 20

Refactor FPDFSaveWithFontSubsetEmbedderTest helper methods [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 1 is the latest

unread,

Refactor FPDFSaveWithFontSubsetEmbedderTest helper methods [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 1 is the latest

Feb 20

Aryan Krishnan (Gerrit), … Pdfium LUCI CQ (Gerrit)10

Feb 20

Privatize OpenSavedDocument() family of methods [pdfium : main]

Pdfium LUCI CQ submitted the change Change information Commit message: Privatize OpenSavedDocument()

unread,

Privatize OpenSavedDocument() family of methods [pdfium : main]

Pdfium LUCI CQ submitted the change Change information Commit message: Privatize OpenSavedDocument()

Feb 20

Tom Sepez (Gerrit), Lei Zhang (Gerrit)5

Feb 20

Remove Agg from names of CFX_AggClipRgn and CFX_AggImageRenderer. [pdfium : main]

Tom Sepez abandoned this change. View Change Abandoned Ok, I have another Idea you might like better.

unread,

Remove Agg from names of CFX_AggClipRgn and CFX_AggImageRenderer. [pdfium : main]

Tom Sepez abandoned this change. View Change Abandoned Ok, I have another Idea you might like better.

Feb 20

Brendan Lundy (Gerrit), … Pdfium LUCI CQ (Gerrit)6

Feb 20

Assume a value of 0 to prevent float-cast-overflow. [pdfium : main]

Pdfium LUCI CQ submitted the change Change information Commit message: Assume a value of 0 to prevent

unread,

Assume a value of 0 to prevent float-cast-overflow. [pdfium : main]

Pdfium LUCI CQ submitted the change Change information Commit message: Assume a value of 0 to prevent

Feb 20

Aryan Krishnan (Gerrit)5

Feb 20

Refine whitespace stripping in CPDF_TextPage [pdfium : main]

Aryan Krishnan abandoned this change. View Change Abandoned Make this a reland of the original CL.

unread,

Refine whitespace stripping in CPDF_TextPage [pdfium : main]

Aryan Krishnan abandoned this change. View Change Abandoned Make this a reland of the original CL.

Feb 20

Lei Zhang (Gerrit)

Feb 20

Fix CFX_GlyphBitmap::GetBitmap() const correctness [pdfium : main]

Attention needed from Tom Sepez Lei Zhang added 1 comment File core/fxge/cfx_renderdevice.cpp Line

unread,

Fix CFX_GlyphBitmap::GetBitmap() const correctness [pdfium : main]

Attention needed from Tom Sepez Lei Zhang added 1 comment File core/fxge/cfx_renderdevice.cpp Line

Feb 20

Aryan Krishnan (Gerrit), … Lei Zhang (Gerrit)17

Feb 20

Remove character width check from cpdf_textpage.cpp [pdfium : main]

Aryan Krishnan added 1 comment File core/fpdftext/cpdf_textpage.cpp Line 843, Patchset 6 (Latest): if

unread,

Remove character width check from cpdf_textpage.cpp [pdfium : main]

Aryan Krishnan added 1 comment File core/fpdftext/cpdf_textpage.cpp Line 843, Patchset 6 (Latest): if

Feb 20

Lei Zhang (Gerrit)

Feb 20

Add metadata-validator to PDFium [pdfium : infra/config]

Attention needed from Jordan Brown Lei Zhang added 3 comments Commit Message Line 9, Patchset 2 (

unread,

Add metadata-validator to PDFium [pdfium : infra/config]

Attention needed from Jordan Brown Lei Zhang added 3 comments Commit Message Line 9, Patchset 2 (

Feb 20

Tom Sepez (Gerrit), … Pdfium LUCI CQ (Gerrit)4

Feb 19

Remove CFX_DIBitmap::TakeOver(). [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 2 is the latest

unread,

Remove CFX_DIBitmap::TakeOver(). [pdfium : main]

Pdfium LUCI CQ submitted the change with unreviewed changes Unreviewed changes 2 is the latest

Feb 19

Lei Zhang (Gerrit)

Feb 19

Assume a value of 0 to prevent overflow. [pdfium : main]

Attention needed from Brendan Lundy Lei Zhang voted and added 6 comments Votes added by Lei Zhang

unread,

Assume a value of 0 to prevent overflow. [pdfium : main]

Attention needed from Brendan Lundy Lei Zhang voted and added 6 comments Votes added by Lei Zhang

Feb 19

Tom Sepez (Gerrit)

Feb 19

Try using a fontations font mgr from Skia when pdf_enable_fontations. [pdfium : main]

Attention needed from Lei Zhang Tom Sepez added 1 comment Patchset-level comments File-level comment,

unread,

Try using a fontations font mgr from Skia when pdf_enable_fontations. [pdfium : main]

Attention needed from Lei Zhang Tom Sepez added 1 comment Patchset-level comments File-level comment,

Feb 19

Tom Sepez (Gerrit), … Pdfium LUCI CQ (Gerrit)4

Feb 19

Rename GetDeviceCache() to GetSkTypeface(). [pdfium : main]

Pdfium LUCI CQ submitted the change Change information Commit message: Rename GetDeviceCache() to

unread,

Rename GetDeviceCache() to GetSkTypeface(). [pdfium : main]

Pdfium LUCI CQ submitted the change Change information Commit message: Rename GetDeviceCache() to

Feb 19

Search

Clear search

Close search

Google apps

Main menu