pdfium-reviews - Google Groups

Groups

Contact owners and managers

1–30 of 20610

0 selected

Tom Sepez (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

Jun 24

Rename CFX_StandardFont::StandardFont to CFX_StandardFont::Index. [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 3

unread,

Rename CFX_StandardFont::StandardFont to CFX_StandardFont::Index. [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 3

Jun 24

Tom Sepez (Gerrit), Lei Zhang (Gerrit)5

Jun 24

Be stricter about CFX_StandarFont::Index. [pdfium : main]

Attention needed from Tom Sepez Lei Zhang voted and added 1 comment Votes added by Lei Zhang Code-

unread,

Be stricter about CFX_StandarFont::Index. [pdfium : main]

Attention needed from Tom Sepez Lei Zhang voted and added 1 comment Votes added by Lei Zhang Code-

Jun 24

Tom Sepez (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)11

Jun 24

Simplify CFX_StandardFont standard font lookup [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

Simplify CFX_StandardFont standard font lookup [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Jun 24

Lei Zhang (Gerrit), Seung Hyun Jin (Gerrit)16

Jun 24

Support pure RTL text in form field through CPVT_section [pdfium : main]

Attention needed from Lei Zhang Seung Hyun Jin added 4 comments Patchset-level comments File-level

unread,

Support pure RTL text in form field through CPVT_section [pdfium : main]

Attention needed from Lei Zhang Seung Hyun Jin added 4 comments Patchset-level comments File-level

Jun 24

Tom Sepez (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)11

Jun 24

Refactor CFX_FontMgr and CFX_FontMapper to break circular dependency [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 9

unread,

Refactor CFX_FontMgr and CFX_FontMapper to break circular dependency [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 9

Jun 24

Lei Zhang (Gerrit), … Helmut Januschka (Gerrit)4

Jun 24

Replace GIF defines with enums and constants [pdfium : main]

Attention needed from Helmut Januschka Lei Zhang voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

Replace GIF defines with enums and constants [pdfium : main]

Attention needed from Helmut Januschka Lei Zhang voted Code-Review+1 Code-Review +1 Open in Gerrit

Jun 24

Tom Sepez (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jun 24

Move standard font data and accessors to CFX_StandardFont [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

Move standard font data and accessors to CFX_StandardFont [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Jun 24

Aryan Krishnan (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)7

Jun 24

Replace FWL_STATE defines with WidgetState enum and Mask [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Replace FWL_STATE defines with WidgetState enum and Mask [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 24

Aryan Krishnan (Gerrit), … Lei Zhang (Gerrit)5

Jun 24

Replace FWL_STYLE_WGT defines with WidgetStyle enum and Mask [pdfium : main]

Attention needed from Aryan Krishnan and Helmut Januschka Lei Zhang voted Code-Review+1 Code-Review +

unread,

Replace FWL_STYLE_WGT defines with WidgetStyle enum and Mask [pdfium : main]

Attention needed from Aryan Krishnan and Helmut Januschka Lei Zhang voted Code-Review+1 Code-Review +

Jun 24

Lei Zhang (Gerrit), … Helmut Januschka (Gerrit)7

Jun 24

Replace BOM macros with constexpr constants [pdfium : main]

Helmut Januschka added 1 comment Commit Message Line 2, Patchset 6 (Latest): Author: chrome builder

unread,

Replace BOM macros with constexpr constants [pdfium : main]

Helmut Januschka added 1 comment Commit Message Line 2, Patchset 6 (Latest): Author: chrome builder

Jun 24

Tom Sepez (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jun 24

Move StandardFont enum and utilities to CFX_StandardFont. [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Move StandardFont enum and utilities to CFX_StandardFont. [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 24

Lei Zhang (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

Jun 24

Replace FX_NUMSTYLE defines with NumStyle enum + Mask [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Replace FX_NUMSTYLE defines with NumStyle enum + Mask [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 24

Aryan Krishnan (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)15

Jun 24

Add FPDFBookmark_GetColor public API [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Add FPDFBookmark_GetColor public API [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 24

Aryan Krishnan (Gerrit), … Lei Zhang (Gerrit)7

Jun 24

Add BrotliDecode filter support for PDF 2.0 streams [pdfium : main]

Attention needed from Andy Phan, Aryan Krishnan and Tom Sepez Lei Zhang added 1 comment File core/

unread,

Add BrotliDecode filter support for PDF 2.0 streams [pdfium : main]

Attention needed from Andy Phan, Aryan Krishnan and Tom Sepez Lei Zhang added 1 comment File core/

Jun 24

Aryan Krishnan (Gerrit), Tom Sepez (Gerrit)4

Jun 24

Add public APIs for Optional Content Groups [pdfium : main]

Attention needed from Andy Phan, Lei Zhang and Tom Sepez Aryan Krishnan voted and added 10 comments

unread,

Add public APIs for Optional Content Groups [pdfium : main]

Attention needed from Andy Phan, Lei Zhang and Tom Sepez Aryan Krishnan voted and added 10 comments

Jun 24

Tom Sepez (Gerrit)

Jun 24

Add additional parallel validation checks in CFX_Face. [pdfium : main]

Attention needed from Chad Brokaw, Dominik Röttsches and Lei Zhang New activity on the change Open in

unread,

Add additional parallel validation checks in CFX_Face. [pdfium : main]

Attention needed from Chad Brokaw, Dominik Röttsches and Lei Zhang New activity on the change Open in

Jun 24

Tom Sepez (Gerrit)

Jun 24

Add parallel checks and make CFX_Face APIs stateless [pdfium : main]

Attention needed from Chad Brokaw, Dominik Röttsches and Lei Zhang New activity on the change Open in

unread,

Add parallel checks and make CFX_Face APIs stateless [pdfium : main]

Attention needed from Chad Brokaw, Dominik Röttsches and Lei Zhang New activity on the change Open in

Jun 24

Tom Sepez (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

Jun 24

Clean up CPVT_VariableText [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Clean up CPVT_VariableText [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 24

Kuka (Gerrit), … Lei Zhang (Gerrit)11

Jun 24

Add timezone offset to new document creation date [pdfium : main]

Attention needed from Kuka and Tom Sepez Lei Zhang added 2 comments File core/fxcrt/fx_extension.cpp

unread,

Add timezone offset to new document creation date [pdfium : main]

Attention needed from Kuka and Tom Sepez Lei Zhang added 2 comments File core/fxcrt/fx_extension.cpp

Jun 24

Tom Sepez (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jun 23

Pass CFX_FontMapper to SystemFontInfoIface::MapFont [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

Pass CFX_FontMapper to SystemFontInfoIface::MapFont [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Jun 23

Lei Zhang (Gerrit), Seung Hyun Jin (Gerrit)2

Jun 23

Support visual rendering for pure RTL text [pdfium : main]

Attention needed from Lei Zhang Seung Hyun Jin added 2 comments Patchset-level comments File-level

unread,

Support visual rendering for pure RTL text [pdfium : main]

Attention needed from Lei Zhang Seung Hyun Jin added 2 comments Patchset-level comments File-level

Jun 23

Lei Zhang (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)8

Jun 23

Refactor CPVT_Word caret calculations [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Refactor CPVT_Word caret calculations [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 23

Tom Sepez (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)7

Jun 23

Pass CFX_FontMapper to CFX_FolderFontInfo methods. [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Pass CFX_FontMapper to CFX_FolderFontInfo methods. [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 23

Tom Sepez (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)7

Jun 23

Refactor manual font table parsing in CFX_FolderFontInfo [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

Refactor manual font table parsing in CFX_FolderFontInfo [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Jun 23

Seung Hyun Jin (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jun 23

Cleanup CPVT_WordInfo constructors [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Cleanup CPVT_WordInfo constructors [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 23

Nicolás Peña (Gerrit), … Lei Zhang (Gerrit)9

Jun 23

Modernize FX_BIDICLASS, FX_BREAKPROPERTY, and FX_CHARTYPE names [pdfium : main]

Attention needed from Helmut Januschka Lei Zhang added 2 comments Patchset-level comments File-level

unread,

Modernize FX_BIDICLASS, FX_BREAKPROPERTY, and FX_CHARTYPE names [pdfium : main]

Attention needed from Helmut Januschka Lei Zhang added 2 comments Patchset-level comments File-level

Jun 23

Tom Sepez (Gerrit), … Lei Zhang (Gerrit)8

Jun 23

Refactor Skrifa integration to use member methods. [pdfium : main]

Lei Zhang added 1 comment File core/fxge/skrifa/src/outlines.cpp Line 43, Patchset 15 (Latest): auto

unread,

Refactor Skrifa integration to use member methods. [pdfium : main]

Lei Zhang added 1 comment File core/fxge/skrifa/src/outlines.cpp Line 43, Patchset 15 (Latest): auto

Jun 23

Lei Zhang (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

Jun 23

Remove unused nTotalWord field from struct CPVT_LineInfo [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

Remove unused nTotalWord field from struct CPVT_LineInfo [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 23

Tom Sepez (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

Jun 22

Fix exponent parsing in CFGAS_StringFormatter::ParseNum backward loop [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

Fix exponent parsing in CFGAS_StringFormatter::ParseNum backward loop [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Jun 22

Tom Sepez (Gerrit), … pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jun 22

Add -Wlifetime-safety-permissive flag and fix CPDF_DIB lifetime warning. [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

Add -Wlifetime-safety-permissive flag and fix CPDF_DIB lifetime warning. [pdfium : main]

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Jun 22

Search

Clear search

Close search

Google apps

Main menu