Issue 1603 in pdfium: Adding vi scrolling keys to pdf viewer

[jacob… via monorail]

Status: Unconfirmed
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1603 by jacob...@gmail.com: Adding vi scrolling keys to pdf viewer
https://bugs.chromium.org/p/pdfium/issues/detail?id=1603

Vimium is a popular extension for adding vim style key bindings to
chrome. Due to how the PDF viewer is implemented, vimium, or other
similar extensions, can't be used for scrolling within it.

Since the H, J, K and L keys have no other function when viewing a PDF
(when not giving form input) I think it would be a nice feature for
these keys to scroll by default.

I think there are a notable number of people who would appreciate this
change. I know at least one other person who would (and I don't know too
many people) and it's a feature which has been requested many times
before:
https://github.com/philc/vimium/issues/723,
https://github.com/philc/vimium/issues/880,
https://github.com/philc/vimium/issues/1243,
https://github.com/philc/vimium/issues/2498,
https://github.com/philc/vimium/issues/3340,
etc.
It doesn't really effect users in any other way.

I've implemented this here: https://chromium-review.googlesource.com/c/chromium/src/+/2498490

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[km… via monorail]

Updates:
Labels: -Type-Defect Type-Enhancement
Mergedinto: chromium:575588
Status: Duplicate

Comment #1 on issue 1603 by km...@chromium.org: Adding vi scrolling keys to pdf viewer
https://bugs.chromium.org/p/pdfium/issues/detail?id=1603#c1

Sorry you went to all this effort first, but we've already decided not to support something like this. It doesn't make sense to do this as the default behavior, rather than an extension.

(Also, this is the bug tracker for the PDFium library, not the Chrome PDF viewer. This sort of bug should be filed under the Chromium project's Internals>Plugins>PDF component.)

[dsinc… via monorail]

Comment #2 on issue 1603 by dsin...@chromium.org: Adding vi scrolling keys to pdf viewer
https://bugs.chromium.org/p/pdfium/issues/detail?id=1603#c2

(Sorry, that was my bad, I directed him here to file the bug. Forgot about the chromium component)

[dsinc… via monorail]

Comment #3 on issue 1603 by dsin...@chromium.org: Adding vi scrolling keys to pdf viewer
https://bugs.chromium.org/p/pdfium/issues/detail?id=1603#c3

[jacob… via monorail]

Comment #4 on issue 1603 by jacob...@gmail.com: Adding vi scrolling keys to pdf viewer
https://bugs.chromium.org/p/pdfium/issues/detail?id=1603#c4

That makes sense - sorry, I didn't find that issue when I was first searching.