Issue 1421 in pdfium: FPDFPageObj_GetFillColor() and FPDFPageObj_GetStrokeColor() can crash

[thes… via monorail]

Status: Accepted
Owner: the...@chromium.org
Labels: Type-Defect Priority-Medium

New issue 1421 by the...@chromium.org: FPDFPageObj_GetFillColor() and FPDFPageObj_GetStrokeColor() can crash
https://bugs.chromium.org/p/pdfium/issues/detail?id=1421

Calling FPDFPageObj_GetFillColor() or FPDFPageObj_GetStrokeColor() on an image object will trigger a crash in CPDF_ColorState::GetFillColorRef() / CPDF_ColorState::GetStrokeColorRef().

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[bugdroid via monorail]

Comment #1 on issue 1421 by bugdroid: FPDFPageObj_GetFillColor() and FPDFPageObj_GetStrokeColor() can crash
https://bugs.chromium.org/p/pdfium/issues/detail?id=1421#c1

The following revision refers to this bug:
https://pdfium.googlesource.com/pdfium/+/b6aa0742e27f9d2164bda49f5b83587e6ff12769

commit b6aa0742e27f9d2164bda49f5b83587e6ff12769
Author: Lei Zhang <the...@chromium.org>
Date: Tue Nov 12 23:15:31 2019

Fix crash in FPDFPageObj_GetFillColor().

Calling FPDFPageObj_GetFillColor() on an image object triggers a crash.
Avoid that and return false. Apply the same fix to
FPDFPageObj_GetStrokeColor(). Add an embedder test for this case.

Bug: pdfium:1421
Change-Id: I62bd33b849434bdbb66830b9fe4549a0ef71f751
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/62355
Reviewed-by: Tom Sepez <tse...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>

[modify] https://pdfium.googlesource.com/pdfium/+/b6aa0742e27f9d2164bda49f5b83587e6ff12769/fpdfsdk/fpdf_editpage_embeddertest.cpp
[modify] https://pdfium.googlesource.com/pdfium/+/b6aa0742e27f9d2164bda49f5b83587e6ff12769/fpdfsdk/fpdf_editpage.cpp

[thes… via monorail]

Updates:
Status: Fixed

Comment #2 on issue 1421 by the...@chromium.org: FPDFPageObj_GetFillColor() and FPDFPageObj_GetStrokeColor() can crash
https://bugs.chromium.org/p/pdfium/issues/detail?id=1421#c2

(No comment was entered for this change.)