Issue 750 in pdfium: PDF annotation popups don't display properly

[janeliu… via monorail]

Updates:
Summary: PDF annotation popups don't display properly

Comment #3 on issue 750 by janel...@google.com: PDF annotation popups don't display properly
https://bugs.chromium.org/p/pdfium/issues/detail?id=750#c3

Dan, I think by "text annotations" you meant annotation popups, correct?

To be more specific, these three bugs illustrate several different problems with how popups display:

1. If the popup has a lot of content, then its text will be truncated, since popups are set to be of a hardcoded fixed size in PDFium. See testing/resources/annotation_highlight_long_content.pdf for a test file.

2. If the annotation is placed too much to the right or the bottom, part of the popup will be cut off, since popups are placed at a hardcoded position relative to the annotation's position. https://crbug.com/645367 and Issue 852 both illustrate this.

3. If the popup sits above some (XFA?) form fields, the fields and text in the fields will be visible even on top of the popup. Issue 852 illustrates this.


--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[bugdro… via monorail]

Comment #4 on issue 750 by bugd...@chromium.org: PDF annotation popups don't display properly
https://bugs.chromium.org/p/pdfium/issues/detail?id=750#c4

The following revision refers to this bug:
https://pdfium.googlesource.com/pdfium/+/3b20ec77c760ef11dacf00a3e654d06cadf20c27

commit 3b20ec77c760ef11dacf00a3e654d06cadf20c27
Author: Jane Liu <janel...@google.com>
Date: Mon Aug 21 16:04:57 2017

Avoid annotation popups to be clipped at page edges

Currently, annotation popups are placed at a fixed location relative to
the annotation. If an annotation is too much on the right or the bottom
of the page, then its popup will be clipped at the edge of the page.

This CL translates the popups appropriately to avoid getting clipped at
page edges. Also, if an annotation is at the bottom-right corner of the
page, then the popup is placed above and to the left of the annotation,
instead of below and to the right of it.

See a set of comparison screenshots here:
https://drive.google.com/drive/folders/0B7Fvv7JszRyGZXZXR05yVEFWSlE?usp=sharing

Bug=chromium:645367,pdfium:750

Change-Id: Ie048281e965523c292dcc704b51188d794f8877b
Reviewed-on: https://pdfium-review.googlesource.com/11470
Commit-Queue: Jane Liu <janel...@google.com>
Reviewed-by: dsinclair <dsin...@chromium.org>

[modify] https://crrev.com/3b20ec77c760ef11dacf00a3e654d06cadf20c27/core/fpdfdoc/cpdf_annotlist.cpp

[n… via monorail]

Updates:
Cc: the...@chromium.org

Comment #6 on issue 750 by ni...@chromium.org: PDF annotation popups don't display properly
https://bugs.chromium.org/p/pdfium/issues/detail?id=750#c6

Hi, the...@chromium.org

Checked all the related bugs https://crbug.com/645367, https://crbug.com/645367 and https://crbug.com/pdfium/852, the following issues are already fixed.
1. content/annotation box is no longer chopped.
2. If the annotation box is over an xfa form field, users' input in these field won't show on top of the annotation popup.

There is still an issue left: if the user select some texts from the PDF file, then hover over an annotation(don't click) and the annotation popup shows above the selected text, the selected section of texts will be a color block displayed on top of the annotation popup. Screenshot and the test file are attached.
If the user click somewhere on the annotation, since the selected texts are no longer selected, this color block will be gone.

Should the color block of selected text be considered as an issue that needs fixing? Other than that, it seems like the 3 issues described in Comment #3 have already been fixed and we can probably close this ticket.

Attachments:
interactiveform_enabled.pdf 89.0 KB
select_text.png 6.2 KB
hover_over_annotation.png 15.4 KB

[km… via monorail]

Comment #8 on issue 750 by km...@chromium.org: PDF annotation popups don't display properly
https://bugs.chromium.org/p/pdfium/issues/detail?id=750#c8

thestig@, can you comment on nigi@'s question in #c6?

[thes… via monorail]

Updates:
Mergedinto: chromium:645367
Status: Duplicate

Comment #9 on issue 750 by the...@chromium.org: PDF annotation popups don't display properly
https://bugs.chromium.org/p/pdfium/issues/detail?id=750#c9

(No comment was entered for this change.)