Issue 71 in pcmanx-gtk2: remove support for gtk < 2.22

17 views
Skip to first unread message

pcman...@googlecode.com

unread,
Nov 14, 2013, 10:52:38 AM11/14/13
to pcm...@googlegroups.com
Status: New
Owner: cmc...@gmail.com
Labels: Type-Defect Priority-Medium

New issue 71 by cmc...@gmail.com: remove support for gtk < 2.22
http://code.google.com/p/pcmanx-gtk2/issues/detail?id=71

Present source use GTK_CHECK_VERSION to do conditional build for backward
compatibility and bug in special version.

However, when we want to port to GTK3, lots of new API are available since
GTK 2.18. The code will be full of lots of ifdef if we still want to keep
the backward compatibility.


GTK 2.22 is released on 2010/09/23 and start to support cairo is one of the
most important feature

The release note for major version
http://freecode.com/projects/gtk/tags/major-feature-enhancements



Linux Distribution Status
Fedora 14 use 2.22
ubuntu 10.04 use 2.20
ubuntu 12.04 use 2.24
debian squeeze use 2.20
OpenSUSE 11.x use 2.22


The supported old version are
src/core/caret.cpp:#if GTK_CHECK_VERSION(2,22,0)
src/core/caret.cpp:#if GTK_CHECK_VERSION(2,22,0)
src/core/caret.cpp:#if GTK_CHECK_VERSION(2,22,0)
src/core/caret.h:#if GTK_CHECK_VERSION(2,22,0)
src/core/termview.cpp:#if GTK_CHECK_VERSION( 2, 10, 13 ) || !
GTK_CHECK_VERSION( 2, 8, 0 )
src/docklet/eggtrayicon.c:#if ! GTK_CHECK_VERSION(2,10,0)
src/docklet/eggtrayicon.c:#endif /* ! GTK_CHECK_VERSION(2,10,0) */
src/mainframe.cpp:#if ! GTK_CHECK_VERSION (2, 10, 0)
src/mainframe.cpp:#if GTK_CHECK_VERSION(2,10,0)
src/mainframe.cpp:#if defined(USE_DOCKLET) && GTK_CHECK_VERSION(2,10,0)
src/mainframe.cpp:#if GTK_CHECK_VERSION(2,10,0)
src/mainframe.cpp:#if GTK_CHECK_VERSION(2,10,0)
src/mainframe.h:#if GTK_CHECK_VERSION(2,10,0)
src/mainframe.h:#if GTK_CHECK_VERSION(2,10,0)
src/pcmanx_gtk2.cpp:#if !GTK_CHECK_VERSION(2,14,0)
src/sitelistdlg.cpp: #if !GTK_CHECK_VERSION(2,6,0)







--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

pcman...@googlecode.com

unread,
Jun 3, 2014, 3:22:17 AM6/3/14
to pcm...@googlegroups.com

Comment #1 on issue 71 by wander...@gmail.com: remove support for gtk < 2.22
http://code.google.com/p/pcmanx-gtk2/issues/detail?id=71

The modification is here:
https://github.com/pcman-bbs/pcmanx/tree/no2.22

Should we merge the branch in this version?

pcman...@googlecode.com

unread,
Jun 6, 2014, 12:01:33 AM6/6/14
to pcm...@googlegroups.com

Comment #2 on issue 71 by wander...@gmail.com: remove support for gtk < 2.22
http://code.google.com/p/pcmanx-gtk2/issues/detail?id=71

The branch has been merged in github.

https://github.com/pcman-bbs/pcmanx

pcman...@googlecode.com

unread,
Nov 17, 2014, 9:24:43 PM11/17/14
to pcm...@googlegroups.com
Updates:
Status: Fixed

Comment #3 on issue 71 by fourdollars: remove support for gtk < 2.22
https://code.google.com/p/pcmanx-gtk2/issues/detail?id=71

(No comment was entered for this change.)
Reply all
Reply to author
Forward
0 new messages