Bug#811751: pcmanx-gtk2: FTBFS with GCC 6: narrowing conversion

[Martin Michlmayr]

Package: pcmanx-gtk2
Version: 1.2-1
Severity: important
User: debia...@lists.debian.org
Usertags: ftbfs-gcc-6 gcc-6-narrowing

This package fails to build with GCC 6. GCC 6 has not been released
yet, but it's expected that GCC 6 will become the default compiler for
stretch.

Note that only the first error is reported; there might be more. You
can find a snapshot of GCC 6 in experimental. To build with GCC 6,
you can set CC=gcc-6 CXX=g++-6 explicitly.

You may be able to find out more about this issue at
https://gcc.gnu.org/gcc-6/changes.html

> sbuild (Debian sbuild) 0.67.0 (26 Dec 2015) on dl580gen9-02.hlinux
...
> g++ -DHAVE_CONFIG_H -I. -I.. -I../src/core -I../src/view -I../src/charset -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/freetype2 -I/usr/include/freetype2 -DLOCALEDIR=\"/usr/share/locale\" -DDATADIR=\"/usr/share\" -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fno-exceptions -fno-rtti -c -o telnetcon.o `test -f 'view/telnetcon.cpp' || echo './'`view/telnetcon.cpp
> view/telnetcon.cpp: In member function 'virtual bool CTelnetCon::Connect()':
> view/telnetcon.cpp:341:19: warning: 'GThread* g_thread_create(GThreadFunc, gpointer, gboolean, GError**)' is deprecated: Use 'g_thread_new' instead [-Wdeprecated-declarations]
> m_DNSThread = g_thread_create( (GThreadFunc)&CTelnetCon::ProcessDNSQueue, NULL, true, NULL);
> ^~~~~~~~~~~~~~~
>
> In file included from /usr/include/glib-2.0/glib.h:107:0,
> from /usr/include/glib-2.0/gobject/gbinding.h:28,
> from /usr/include/glib-2.0/glib-object.h:23,
> from /usr/include/glib-2.0/gio/gioenums.h:28,
> from /usr/include/glib-2.0/gio/giotypes.h:28,
> from /usr/include/glib-2.0/gio/gio.h:26,
> from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
> from /usr/include/gtk-2.0/gdk/gdk.h:32,
> from /usr/include/gtk-2.0/gtk/gtk.h:32,
> from view/telnetcon.h:32,
> from view/telnetcon.cpp:31:
> /usr/include/glib-2.0/glib/deprecated/gthread.h:104:10: note: declared here
> GThread *g_thread_create (GThreadFunc func,
> ^~~~~~~~~~~~~~~
>
> view/telnetcon.cpp:341:95: warning: 'GThread* g_thread_create(GThreadFunc, gpointer, gboolean, GError**)' is deprecated: Use 'g_thread_new' instead [-Wdeprecated-declarations]
> m_DNSThread = g_thread_create( (GThreadFunc)&CTelnetCon::ProcessDNSQueue, NULL, true, NULL);
> ^
>
> In file included from /usr/include/glib-2.0/glib.h:107:0,
> from /usr/include/glib-2.0/gobject/gbinding.h:28,
> from /usr/include/glib-2.0/glib-object.h:23,
> from /usr/include/glib-2.0/gio/gioenums.h:28,
> from /usr/include/glib-2.0/gio/giotypes.h:28,
> from /usr/include/glib-2.0/gio/gio.h:26,
> from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
> from /usr/include/gtk-2.0/gdk/gdk.h:32,
> from /usr/include/gtk-2.0/gtk/gtk.h:32,
> from view/telnetcon.h:32,
> from view/telnetcon.cpp:31:
> /usr/include/glib-2.0/glib/deprecated/gthread.h:104:10: note: declared here
> GThread *g_thread_create (GThreadFunc func,
> ^~~~~~~~~~~~~~~
>
> view/telnetcon.cpp: In member function 'void CTelnetCon::ParseTelnetCommand()':
> view/telnetcon.cpp:465:38: error: narrowing conversion of '255u' from 'unsigned char' to 'char' inside { } [-Wnarrowing]
> char ret[]={TC_IAC,TC_DONT,*m_pBuf};
> ^
>
> view/telnetcon.cpp:465:38: error: narrowing conversion of '254u' from 'unsigned char' to 'char' inside { } [-Wnarrowing]
> view/telnetcon.cpp:465:31: warning: narrowing conversion of '*((CTelnetCon*)this)->CTelnetCon::m_pBuf' from 'unsigned char' to 'char' inside { } [-Wnarrowing]
> char ret[]={TC_IAC,TC_DONT,*m_pBuf};
> ^~~~~~~
>
> view/telnetcon.cpp:480:38: error: narrowing conversion of '255u' from 'unsigned char' to 'char' inside { } [-Wnarrowing]
> char ret[]={TC_IAC,TC_WILL,*m_pBuf};
> ^
>
> view/telnetcon.cpp:480:38: error: narrowing conversion of '251u' from 'unsigned char' to 'char' inside { } [-Wnarrowing]
> view/telnetcon.cpp:480:31: warning: narrowing conversion of '*((CTelnetCon*)this)->CTelnetCon::m_pBuf' from 'unsigned char' to 'char' inside { } [-Wnarrowing]

--
Martin Michlmayr
Linux for HPE Helion, Hewlett Packard Enterprise

[Debian Bug Tracking System]

Your message dated Wed, 2 Mar 2016 16:16:19 -0800
with message-id <20160303001...@jirafa.cyrius.com>
and subject line Re: Bug#811751: pcmanx-gtk2: FTBFS with GCC 6: narrowing conversion
has caused the Debian Bug report #811751,
regarding pcmanx-gtk2: FTBFS with GCC 6: narrowing conversion
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


--
811751: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=811751
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems