Inlineing in the *layer* headers?

16 views
Skip to first unread message

Robert Szokovacs

unread,
Feb 10, 2022, 9:39:15 AM2/10/22
to PcapPlusPlus support
Hi,

I'm reading the source of Packet++ and noticed that every layer implementation has a get*Header() function that returns a pointer to a memory address, and it is later used by other functions (get/set address, etc.). I think this functions (and the get/set ones, too) would benefit from inlineing. Alternatively, if there is something preventing making the get*header inline, we should use the explicit pointer in the get/set functions.
I'm prepared to make the change if there is no objections!

br
Szo
Reply all
Reply to author
Forward
0 new messages