Typo in tutorial 4, packet parsing.

[dewisantf...@gmail.com]

 The "empty" starting code would not compile for non-windows platforms,

as it has a #include without a filename. It should read:

#if !defined(WIN32) && !defined(WINx64)
#include <arpa/inet.h> // this is for using ntohs() and htons() on non-Windows OS's
#endif

[PcapPlusPlus Support]

You're right, thanks for noticing and reporting this typo!

I'll fix it soon.

Thanks,

PcapPlusPlus maintainer

--
You received this message because you are subscribed to the Google Groups "PcapPlusPlus support" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pcapplusplus-sup...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/pcapplusplus-support/22ba0f49-1fae-4e0c-ba4b-a217074a5caao%40googlegroups.com.

[PcapPlusPlus Support]

BTW, if you'd consider to make the change and submit a PR that'd be great.

Thanks,

PcapPlusPlus maintainer

[dewisantf...@gmail.com]

This isn't in the codebase but on the tutorial web pages at https://pcapplusplus.github.io/docs/tutorials/packet-parsing

Can I edit that?

On Thursday, 16 July 2020 10:42:10 UTC+1, PcapPlusPlus Support wrote:

BTW, if you'd consider to make the change and submit a PR that'd be great.

Thanks,

PcapPlusPlus maintainer

On Fri, Jul 10, 2020 at 2:30 AM PcapPlusPlus Support <pcappl...@gmail.com> wrote:

You're right, thanks for noticing and reporting this typo!

I'll fix it soon.

Thanks,

PcapPlusPlus maintainer

On Thu, Jul 9, 2020 at 1:49 AM <dewisantf...@gmail.com> wrote:

 The "empty" starting code would not compile for non-windows platforms,

as it has a #include without a filename. It should read:

#if !defined(WIN32) && !defined(WINx64)
#include <arpa/inet.h> // this is for using ntohs() and htons() on non-Windows OS's
#endif

--
You received this message because you are subscribed to the Google Groups "PcapPlusPlus support" group.

To unsubscribe from this group and stop receiving emails from it, send an email to pcapplusplus-support+unsub...@googlegroups.com.

[PcapPlusPlus Support]

Yes, of course!

The docs repo is: https://github.com/PcapPlusPlus/pcapplusplus.github.io,

The page for this specific tutorial is: https://github.com/PcapPlusPlus/pcapplusplus.github.io/blob/master/docs/tutorials/packet-parsing.md

And the tutorial code is in the main PcapPlusPlus repo: https://github.com/seladb/PcapPlusPlus/tree/master/Examples/Tutorials/Tutorial-PacketParsing

Thanks,

PcapPlusPlus maintainer

On Mon, Jul 20, 2020 at 12:29 AM <dewisantf...@gmail.com> wrote:

This isn't in the codebase but on the tutorial web pages at https://pcapplusplus.github.io/docs/tutorials/packet-parsing

Can I edit that?

On Thursday, 16 July 2020 10:42:10 UTC+1, PcapPlusPlus Support wrote:

BTW, if you'd consider to make the change and submit a PR that'd be great.

Thanks,

PcapPlusPlus maintainer

On Fri, Jul 10, 2020 at 2:30 AM PcapPlusPlus Support <pcappl...@gmail.com> wrote:

You're right, thanks for noticing and reporting this typo!

I'll fix it soon.

Thanks,

PcapPlusPlus maintainer

On Thu, Jul 9, 2020 at 1:49 AM <dewisantf...@gmail.com> wrote:

 The "empty" starting code would not compile for non-windows platforms,

as it has a #include without a filename. It should read:

#if !defined(WIN32) && !defined(WINx64)
#include <arpa/inet.h> // this is for using ntohs() and htons() on non-Windows OS's
#endif

--
You received this message because you are subscribed to the Google Groups "PcapPlusPlus support" group.

To unsubscribe from this group and stop receiving emails from it, send an email to pcapplusplus-sup...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/pcapplusplus-support/22ba0f49-1fae-4e0c-ba4b-a217074a5caao%40googlegroups.com.

--

You received this message because you are subscribed to the Google Groups "PcapPlusPlus support" group.

To unsubscribe from this group and stop receiving emails from it, send an email to pcapplusplus-sup...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/pcapplusplus-support/b341ffb4-5192-4019-836f-e1563c535b3fo%40googlegroups.com.