openexr possible wrong cmake file

[Thierry Backes]

Hey, I tried compiling pbrt-v3 from scratch on osx as well as fedora, and both times, I had to change the cmake file /src/ext/openexr/CMakeLists.txt :

from:

add_custom_target(CopyIlmBaseLibs
  COMMAND ${CMAKE_COMMAND} -E copy_directory
  ${CMAKE_CURRENT_BINARY_DIR}/IlmBase/Half/$<CONFIGURATION>
  ${CMAKE_CURRENT_BINARY_DIR}/OpenEXR/IlmImf/$<CONFIGURATION>
  COMMAND ${CMAKE_COMMAND} -E copy_directory
  ${CMAKE_CURRENT_BINARY_DIR}/IlmBase/IlmThread/$<CONFIGURATION>
  ${CMAKE_CURRENT_BINARY_DIR}/OpenEXR/IlmImf/$<CONFIGURATION>
  COMMAND ${CMAKE_COMMAND} -E copy_directory
  ${CMAKE_CURRENT_BINARY_DIR}/IlmBase/Iex/$<CONFIGURATION>
  ${CMAKE_CURRENT_BINARY_DIR}/OpenEXR/IlmImf/$<CONFIGURATION>
  COMMAND ${CMAKE_COMMAND} -E copy_directory
  ${CMAKE_CURRENT_BINARY_DIR}/IlmBase/Imath/$<CONFIGURATION>
  ${CMAKE_CURRENT_BINARY_DIR}/OpenEXR/IlmImf/$<CONFIGURATION>
)

to

add_custom_target(CopyIlmBaseLibs
  COMMAND ${CMAKE_COMMAND} -E copy_directory
  ${CMAKE_CURRENT_BINARY_DIR}/IlmBase/Half/
  ${CMAKE_CURRENT_BINARY_DIR}/OpenEXR/IlmImf/
  COMMAND ${CMAKE_COMMAND} -E copy_directory
  ${CMAKE_CURRENT_BINARY_DIR}/IlmBase/IlmThread/
  ${CMAKE_CURRENT_BINARY_DIR}/OpenEXR/IlmImf/
  COMMAND ${CMAKE_COMMAND} -E copy_directory
  ${CMAKE_CURRENT_BINARY_DIR}/IlmBase/Iex/
  ${CMAKE_CURRENT_BINARY_DIR}/OpenEXR/IlmImf/
  COMMAND ${CMAKE_COMMAND} -E copy_directory
  ${CMAKE_CURRENT_BINARY_DIR}/IlmBase/Imath/
  ${CMAKE_CURRENT_BINARY_DIR}/OpenEXR/IlmImf/
)

Am I doing something wrong, or is $<CONFIGURATION> not defined?

Thanks

[Matt Pharr]

I suspect you're hitting this issue: https://github.com/mmp/pbrt-v3/issues/196. Sorry that's not fixed yet in the underlying exr libraries!

Thanks,

Matt

--
You received this message because you are subscribed to the Google Groups "pbrt" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pbrt+uns...@googlegroups.com.
To post to this group, send email to pb...@googlegroups.com.
Visit this group at https://groups.google.com/group/pbrt.
For more options, visit https://groups.google.com/d/optout.

[Thierry Backes]

Yes, it seems like that's the same issue. Thank you, I got it working!

Thierry