On Mon, Dec 25, 2017 at 12:44 AM, Pál Mezei <
sirp...@gmail.com> wrote:
>
> I took a quick stab at the travis setup here :
https://github.com/sirpalee/partio/tree/travis .
>
> Strangely the c++11 flags are missing from cmake in the master branch, yet one of the files are using unique_ptrs.
>
> David, how do you feel about modernizing the cmake setup and going for the 2018 VFX standard. (since both the merging in and the codebase modernization will happen next year anyway)
Thanks, that sounds like a good thing to do.
Regarding the C++11 settings, CMakelists.txt has this line, which may
explain why those worked:
add_compile_options(-std=c++11)
We should already be on C++11 so if there are missing flags it's
probably an oversight. Nonetheless, we should make it easier to
opt-in to newer (C++14) configurations rather than having it
hard-coded.
Making it opt-in allows someone stuck using an older setup to still
build the latest (vfx2018+) code using their C++11 compilers. This
implies that we should at least try to maintain C++11 source-level
compatibility for now since those constructs should be
forwards-compatible to newer standards.
We can use #defines to swap-in use of newer features as needed.
Partio is pretty simple so this shouldn't be a big concern. Most of
the code is already on C++11 so for the most part it's just a matter
of making it easier to adjust the compiler flags for newer standards.
--
David