IdentifierSource visibility

[Nick Tindall]

Hi All,

Just doing some work with parfait at the moment and when attempting to implement a custom IdentifierSourceSet, we made the realisation that the IdentifierSource interface is package private. It has some public implementations (WarningIdentifierSource, ErrorThrowingIdentifierSource and FixedValueIdentifierSource) so it's possible to implement IdentifierSourceSet, but limited to the use of combinations of those public IdentifierSource implementations.

I've spoken to Paul Smith and Yoram Kulbak about it and neither were aware of any specific design decision being made to make IdentifierSource package private, so am just wondering if anyone would object to us making it public?

We'd probably be looking at making HashingIdentifierSource public also.

Any input is appreciated.

Regards,

Nick Tindall