Review Request 4393: Prepare the 1.3.0dev2 release.

1 view
Skip to first unread message

Mateo Rodriguez

unread,
Nov 18, 2016, 6:13:35 PM11/18/16
to Stu Hood, Benjy Weinberger, Eric Ayers, Kris Wilson, pants-reviews, Mateo Rodriguez
This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4393/

Review request for pants-reviews, Benjy Weinberger, Kris Wilson, Stu Hood, and Eric Ayers.
By Mateo Rodriguez.
Repository: pants

Description 

Prepare the 1.3.0dev2 release.

Testing 

Manually added the Gitub-reviewed links.

Diffs

  • CONTRIBUTORS.md (3ed3ae9f72bb5b46edb803e2c82cb9f4659d61ca)
  • src/python/pants/notes/master.rst (d8bf445430c659d797001f914a72d880d05daa40)
  • src/python/pants/version.py (52800c04c089f5310e1902d475f4b7cac42a6faf)

View Diff

Mateo Rodriguez

unread,
Nov 18, 2016, 6:18:11 PM11/18/16
to Stu Hood, Benjy Weinberger, Eric Ayers, Kris Wilson, pants-reviews, Mateo Rodriguez
This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4393/

Review request for pants-reviews, Benjy Weinberger, Kris Wilson, Stu Hood, and Eric Ayers.
By Mateo Rodriguez.

Updated Nov. 18, 2016, 5:18 p.m.

Changes

Travis is away. I am getting a local python module error, but I also was messing with buildgen in the pantsenv, which borks things :/


23:09:38 00:08           [eval]

                         Failed to eval tests/python/pants_test/cache:cache_server
Failed to eval 'file tests/python/pants_test/cache/cache_server.py':
  File "[srcroot]/pants_test/cache/cache_server.py", line 16, in <module>
    from pants.util.contextutil import pushd, temporary_dir
  File "/Users/mateo/dev/pants/src/python/pants/util/contextutil.py", line 18, in <module>
    from colors import green
No module named colors





I will verify I have a local green and update accordingly.
Bugs: 4080

Mateo Rodriguez

unread,
Nov 18, 2016, 7:40:36 PM11/18/16
to Stu Hood, Benjy Weinberger, Eric Ayers, Kris Wilson, pants-reviews, Mateo Rodriguez
This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4393/

Review request for pants-reviews, Benjy Weinberger, Kris Wilson, Stu Hood, and Eric Ayers.
By Mateo Rodriguez.

Updated Nov. 18, 2016, 6:40 p.m.

Changes

Fix some whitespace.


The dry-run of the release was green locally. Travis revealed some whitespace errors in the master.rst, which are fixed here.
./pants markdown --fragment src/python/pants/notes:: failed before this change and now passes.
Bugs: 4080
Repository: pants

Description 

Prepare the 1.3.0dev2 release.

Testing 

Manually added the Gitub-reviewed links.

Diffs (updated)

  • CONTRIBUTORS.md (3ed3ae9f72bb5b46edb803e2c82cb9f4659d61ca)
  • src/python/pants/notes/master.rst (d8bf445430c659d797001f914a72d880d05daa40)
  • src/python/pants/version.py (52800c04c089f5310e1902d475f4b7cac42a6faf)

View Diff

Reply all
Reply to author
Forward
0 new messages