Review Request 1742: Pass the BUILD file path to compile.

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/1742/

Review request for pants-reviews and Nick Howard (Twitter). By John Sirois. Bugs: 1067 Repository: pants Description This produces SyntaxErrors with the path to the bad BUILD file included in the error details. src/python/pants/base/build_file.py | 2 +- tests/python/pants_test/base/BUILD | 2 +- tests/python/pants_test/base/test_build_file.py | 211 +++++++++++++++++++++++++++----------------------- 3 files changed, 115 insertions(+), 100 deletions(-) Testing CI went green here: https://travis-ci.org/pantsbuild/pants/builds/50115987 Diffs src/python/pants/base/build_file.py (3b532753638a4b0059b0f03b912a0e4c3dd1557a) tests/python/pants_test/base/BUILD (d8713760078b0b5040ad86ee61fdce0fdc093fe6) tests/python/pants_test/base/test_build_file.py (805141a49ac124f34692985ac8c85d171ad691b8) View Diff

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/1742/

ping

- John Sirois

On February 9th, 2015, 2:33 p.m. MST, John Sirois wrote:

Review request for pants-reviews and Nick Howard (Twitter). By John Sirois.

Updated Feb. 9, 2015, 2:33 p.m.

[Jin Feng]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/1742/

Ship it!

Ship It!

- Jin Feng

On February 9th, 2015, 1:33 p.m. PST, John Sirois wrote:

Review request for pants-reviews and Nick Howard (Twitter). By John Sirois.

Updated Feb. 9, 2015, 1:33 p.m.

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/1742/

Thanks Jin - submitted @ https://github.com/pantsbuild/pants/commit/274df6c844634675af7d6f1657f14840e3480f25

- John Sirois

On February 10th, 2015, 5:41 p.m. MST, John Sirois wrote:

Review request for pants-reviews, Jin Feng and Nick Howard (Twitter). By John Sirois. Updated Feb. 10, 2015, 5:41 p.m.

[Patrick Lawson]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/1742/

tests/python/pants_test/base/test_build_file.py (Diff revision 1)
		201	parsed_locals = Compatibility.exec_function(build_file.code(), {'java_library': dict})

Sorry for the late review--we should always be using six equivalents rather than introducing new deps on t.c.*.; e.g. https://pythonhosted.org/six/#six.exec_

- Patrick Lawson

On February 11th, 2015, 12:41 a.m. UTC, John Sirois wrote:

Review request for pants-reviews, Jin Feng and Nick Howard (Twitter). By John Sirois.

Updated Feb. 11, 2015, 12:41 a.m.

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/1742/

On February 11th, 2015, 9:18 a.m. MST, Patrick Lawson wrote:

tests/python/pants_test/base/test_build_file.py (Diff revision 1)
		201	parsed_locals = Compatibility.exec_function(build_file.code(), {'java_library': dict})

Sorry for the late review--we should always be using six equivalents rather than introducing new deps on t.c.*.; e.g. https://pythonhosted.org/six/#six.exec_

Fixed up here: https://rbcommons.com/s/twitter/r/1794/

- John

On February 10th, 2015, 5:41 p.m. MST, John Sirois wrote:

Review request for pants-reviews, Jin Feng and Nick Howard (Twitter). By John Sirois.

Updated Feb. 10, 2015, 5:41 p.m. Bugs: 1067