Review Request 4390: Revert "Adds documentation for running scala tests to both the JVM area and the scala area"

0 views
Skip to first unread message

John Sirois

unread,
Nov 17, 2016, 9:57:11 PM11/17/16
to Peiyu Wang, Stu Hood, pants-reviews, John Sirois
This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4390/

Review request for pants-reviews, Peiyu Wang and Stu Hood.
By John Sirois.
Bugs: 4064, 4069
Repository: pants

Description

This reverts commit f400a03fb050f925e75c477a77ccafb14ba58603.

This change breaks ITs, reverting until those can be fixed up.

 examples/src/java/org/pantsbuild/example/README.md  | 10 ++--------
 examples/src/scala/org/pantsbuild/example/README.md |  6 ------
 2 files changed, 2 insertions(+), 14 deletions(-)

Testing

CI is away here:
  https://travis-ci.org/pantsbuild/pants/builds/176910506

Diffs

  • examples/src/java/org/pantsbuild/example/README.md (735b8bcf21a35172c98faf32ea4ab6e02e4b0569)
  • examples/src/scala/org/pantsbuild/example/README.md (ec05aef6c9593bd1fee427143328b9a8a551e84a)

View Diff

John Sirois

unread,
Nov 17, 2016, 10:15:58 PM11/17/16
to Peiyu Wang, Stu Hood, pants-reviews, John Sirois
This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4390/

OK - not reverting after all, does not fix CI issue, instead skipping some tests pending #4010.
I'll post a new RB for that.

- John Sirois


On November 17th, 2016, 7:57 p.m. MST, John Sirois wrote:

Review request for pants-reviews, Peiyu Wang and Stu Hood.
By John Sirois.

Updated Nov. 17, 2016, 7:57 p.m.

Reply all
Reply to author
Forward
0 new messages