Review Request 4354: Adding a Code of Conduct

[Nick Howard (Twitter)]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4354/

Review request for pants-reviews, Benjy Weinberger, Ity Kaul, John Sirois, Stu Hood, and Eric Ayers. By Nick Howard (Twitter). Bugs: 4031 Repository: pants Description This patch adds a code of conduct based on the TODOGroup / Twitter OSS code of conduct. The google doc used for initial drafting is https://docs.google.com/document/d/1cNM06FcKJ7CHdWvlAx55b0ZRG2-9pgv23teO6wEyJcQ/edit#. I'm planning on aliasing pants-conduct to pants-committers as a starting point. I just linked the response team to COMMITTERS.md. I think it can be better though. Thoughts? Diffs CODE_OF_CONDUCT.md (4418b3b37a16bbd550a050d212b6aeb2a07c3185) View Diff

[Benjy Weinberger]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4354/

Ship it!

Looks great! Thanks so much for handling this.

- Benjy Weinberger

On November 10th, 2016, 11:04 p.m. UTC, Nick Howard (Twitter) wrote:

Review request for pants-reviews, Benjy Weinberger, Ity Kaul, John Sirois, Stu Hood, and Eric Ayers. By Nick Howard (Twitter).

Updated Nov. 10, 2016, 11:04 p.m.

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4354/

Ship it!

Ship It!

- John Sirois

On November 10th, 2016, 4:04 p.m. MST, Nick Howard (Twitter) wrote:

Review request for pants-reviews, Benjy Weinberger, Ity Kaul, John Sirois, Stu Hood, and Eric Ayers. By Nick Howard (Twitter).

Updated Nov. 10, 2016, 4:04 p.m.

[Stu Hood]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4354/

Ship it!

Would you mind linking this into the site somewhere? Please see http://www.pantsbuild.org/docs.html

- Stu Hood

On November 10th, 2016, 11:04 p.m. UTC, Nick Howard (Twitter) wrote:

Review request for pants-reviews, Benjy Weinberger, Ity Kaul, John Sirois, Stu Hood, and Eric Ayers. By Nick Howard (Twitter).

Updated Nov. 10, 2016, 11:04 p.m. Bugs: 4031

[Nick Howard (Twitter)]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4354/

Review request for pants-reviews, Benjy Weinberger, Ity Kaul, John Sirois, Stu Hood, and Eric Ayers. By Nick Howard (Twitter).

Updated Nov. 14, 2016, 11:23 a.m. Changes Add link to code of conduct on index page.

Bugs: 4031 Repository: pants Description This patch adds a code of conduct based on the TODOGroup / Twitter OSS code of conduct. The google doc used for initial drafting is https://docs.google.com/document/d/1cNM06FcKJ7CHdWvlAx55b0ZRG2-9pgv23teO6wEyJcQ/edit#. I'm planning on aliasing pants-conduct to pants-committers as a starting point. I just linked the response team to COMMITTERS.md. I think it can be better though. Thoughts?

Diffs (updated) CODE_OF_CONDUCT.md (4418b3b37a16bbd550a050d212b6aeb2a07c3185) src/docs/index.md (4ac382c5d178b0b3c713037b2b86eff17b813607) View Diff Show Changes

[Stu Hood]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4354/

src/docs/index.md (Diff revision 2)
		49	+ [Code of Conduct](https://github.com/pantsbuild/pants/blob/master/CODE_OF_CONDUCT.md)

So, ideally you would actually include it in the site, rather than just linking to it...? But fine for now I suppose.

- Stu Hood

On November 14th, 2016, 6:23 p.m. UTC, Nick Howard (Twitter) wrote:

Review request for pants-reviews, Benjy Weinberger, Ity Kaul, John Sirois, Stu Hood, and Eric Ayers. By Nick Howard (Twitter).

Updated Nov. 14, 2016, 6:23 p.m.

Bugs: 4031 Repository: pants Description This patch adds a code of conduct based on the TODOGroup / Twitter OSS code of conduct. The google doc used for initial drafting is https://docs.google.com/document/d/1cNM06FcKJ7CHdWvlAx55b0ZRG2-9pgv23teO6wEyJcQ/edit#. I'm planning on aliasing pants-conduct to pants-committers as a starting point. I just linked the response team to COMMITTERS.md. I think it can be better though. Thoughts? Diffs

[Ity Kaul]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4354/

Ship it!

Ship It!

- Ity Kaul

On November 14th, 2016, 10:23 a.m. PST, Nick Howard (Twitter) wrote:

Review request for pants-reviews, Benjy Weinberger, Ity Kaul, John Sirois, Stu Hood, and Eric Ayers. By Nick Howard (Twitter).

Updated Nov. 14, 2016, 10:23 a.m.

Bugs: 4031 Repository: pants Description This patch adds a code of conduct based on the TODOGroup / Twitter OSS code of conduct. The google doc used for initial drafting is https://docs.google.com/document/d/1cNM06FcKJ7CHdWvlAx55b0ZRG2-9pgv23teO6wEyJcQ/edit#. I'm planning on aliasing pants-conduct to pants-committers as a starting point. I just linked the response team to COMMITTERS.md. I think it can be better though. Thoughts? Diffs

[Nick Howard (Twitter)]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4354/

On November 14th, 2016, 12:10 p.m. MST, Stu Hood wrote:

src/docs/index.md (Diff revision 2)
		49	+ [Code of Conduct](https://github.com/pantsbuild/pants/blob/master/CODE_OF_CONDUCT.md)

So, ideally you would actually include it in the site, rather than just linking to it...? But fine for now I suppose.

Yeah. I considered that. My thought was that the places where it needs to be more visible are in the root of the repo, for new contributors and in the docs. I could hoist it into src/docs and link to it via the README.md and CODE_OF_CONDUCT.md instead.
As is, this gets it out there and we can iterate on it.

- Nick

On November 14th, 2016, 11:23 a.m. MST, Nick Howard (Twitter) wrote:

Review request for pants-reviews, Benjy Weinberger, Ity Kaul, John Sirois, Stu Hood, and Eric Ayers. By Nick Howard (Twitter).

Updated Nov. 14, 2016, 11:23 a.m.