Review Request 4379: Add contrib, 3rdparty to copy list for mock buildroot

0 views
Skip to first unread message

Yi Cheng

unread,
Nov 15, 2016, 5:12:41 PM11/15/16
to Nick Howard (Twitter), Yujie Chen, Kris Wilson, pants-reviews, Yi Cheng
This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4379/

Review request for pants-reviews, Kris Wilson, Nick Howard (Twitter), and Yujie Chen.
By Yi Cheng.
Bugs: 4056
Repository: pants

Description

Add contrib, 3rdparty to copy list for mock buildroot as v2 engine to pass prefix checks.

Testing

https://travis-ci.org/pantsbuild/pants/builds/176184104 (v2 engine on, shard 9 passed) https://travis-ci.org/pantsbuild/pants/builds/176194952 (regular v1 run)

Diffs

  • tests/python/pants_test/pants_run_integration_test.py (1d25f348e7ec4eb3802eb7c163034b049fd472a3)

View Diff

Yujie Chen

unread,
Nov 15, 2016, 5:35:29 PM11/15/16
to Nick Howard (Twitter), Yujie Chen, Kris Wilson, pants-reviews, Yi Cheng
This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4379/

Ship it!

Ship It!

- Yujie Chen


On November 15th, 2016, 5:12 p.m. EST, Yi Cheng wrote:

Review request for pants-reviews, Kris Wilson, Nick Howard (Twitter), and Yujie Chen.
By Yi Cheng.

Updated Nov. 15, 2016, 5:12 p.m.

Reply all
Reply to author
Forward
0 new messages