Review Request 4391: Skip failing tests to get CI green.

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4391/

Review request for pants-reviews, Peiyu Wang and Stu Hood. By John Sirois. Bugs: 4064, 4070 Repository: pants Description In this case there is no simple revert to fix. src/python/pants/engine/subsystem/native_engine_version | 2 +- tests/python/pants_test/engine/legacy/test_changed_integration.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) Testing Locally green now: ./pants test tests/python/pants_test/engine/legacy:changed_integration CI is away here: https://travis-ci.org/pantsbuild/pants/builds/176914109 Diffs src/python/pants/engine/subsystem/native_engine_version (79d4d2ece129319e0f6ab2c40afac24d27acad70) tests/python/pants_test/engine/legacy/test_changed_integration.py (a4afcdca21d20b2d699993ee09680d714546323c) View Diff

[Peiyu Wang]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4391/

Ship it!

looks like 4010 is closed as dup of https://github.com/pantsbuild/pants/issues/3563

- Peiyu Wang

On November 18th, 2016, 3:22 a.m. UTC, John Sirois wrote:

Review request for pants-reviews, Peiyu Wang and Stu Hood. By John Sirois.

Updated Nov. 18, 2016, 3:22 a.m.

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4391/

On November 17th, 2016, 8:24 p.m. MST, Peiyu Wang wrote:

looks like 4010 is closed as dup of https://github.com/pantsbuild/pants/issues/3563

Thanks - I'll leave the @skip comments as is to save CI time and get this in master asap, but updated RBs and issues to point to the right place.

- John

On November 17th, 2016, 8:22 p.m. MST, John Sirois wrote:

Review request for pants-reviews, Peiyu Wang and Stu Hood. By John Sirois.

Updated Nov. 17, 2016, 8:22 p.m.

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4391/

Review request for pants-reviews, Peiyu Wang and Stu Hood. By John Sirois.

Updated Nov. 17, 2016, 8:27 p.m. Bugs: 3563, 4064, 4070

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4391/

Review request for pants-reviews, Peiyu Wang and Stu Hood. By John Sirois.

Updated Nov. 17, 2016, 9:42 p.m.

Bugs: 3563, 4064, 4070 Repository: pants Description In this case there is no simple revert to fix. src/python/pants/engine/subsystem/native_engine_version | 2 +- tests/python/pants_test/engine/legacy/test_changed_integration.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-)

Testing (updated)

Locally green now: ./pants test tests/python/pants_test/engine/legacy:changed_integration

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/176914109