Re: Review Request 4385: Adds documentation for running scala tests

0 views
Skip to first unread message

Stu Hood

unread,
Nov 16, 2016, 4:15:02 PM11/16/16
to Stu Hood, pants-reviews, Dave Brewster
This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4385/

Ship it! 

Thanks!


Would be good to actually mention the fully-qualified class to extend... (and ditto for the RunWith mention, maybe?)

examples/src/java/org/pantsbuild/example/README.md (Diff revision 1) 

    75
    
> testing framework automatically picks up scala tests and runs them

  


 




 


  
s/picks up scala tests/picks up tests that extend org.scalatest.Suite/

 









- Stu Hood






On November 16th, 2016, 9:08 p.m. UTC, Dave Brewster wrote:











 

  


Review request for pants-reviews and Stu Hood.


By Dave Brewster.




Updated Nov. 16, 2016, 9:08 p.m.










 Bugs: 


 4064









 Repository: 
pants





Description 

 

 

  
   
Adds documentation for running scala tests to both the JVM area and the scala area

  		
 









Diffs 


    

 
  • examples/src/java/org/pantsbuild/example/README.md (a004f35ae9660ed3ab5d400dab61e856d0ef0bbf)
    • 

 
  • examples/src/scala/org/pantsbuild/example/README.md (be54a6dd09e4d46687c7c872f484403eef5af3b9)
    • 






View Diff











  		
 










  

 




John Sirois
unread,
Nov 17, 2016, 9:58:01 PM11/17/16
to Stu Hood, pants-reviews, Dave Brewster, John Sirois

   

    

     
      This is an automatically generated e-mail. To reply, visit:
      https://rbcommons.com/s/twitter/r/4385/
     
    

   

   






 
This broke CI both in the PR, and of course when it landed on master. I'm preparing the revert here: https://rbcommons.com/s/twitter/r/4390/

 











- John Sirois






On November 16th, 2016, 2:40 p.m. MST, Dave Brewster wrote:













Review request for pants-reviews and Stu Hood.


By Dave Brewster.




Updated Nov. 16, 2016, 2:40 p.m.
John Sirois
unread,
Nov 17, 2016, 10:22:45 PM11/17/16
to Stu Hood, pants-reviews, Dave Brewster, John Sirois

   

    

     
      This is an automatically generated e-mail. To reply, visit:
      https://rbcommons.com/s/twitter/r/4385/
     
    

   

   








 
On November 17th, 2016, 7:58 p.m. MST, John Sirois wrote:

 

  
This broke CI both in the PR, and of course when it landed on master. I'm preparing the revert here: https://rbcommons.com/s/twitter/r/4390/

 












Actually, here: https://rbcommons.com/s/twitter/r/4391/
The break was indirect.














- John
John Sirois
unread,
Nov 17, 2016, 10:23:02 PM11/17/16
to Stu Hood, pants-reviews, Dave Brewster, John Sirois

   

    

     
      This is an automatically generated e-mail. To reply, visit:
      https://rbcommons.com/s/twitter/r/4385/
     
    

   

   








 
On November 17th, 2016, 7:58 p.m. MST, John Sirois wrote:

 

  
This broke CI both in the PR, and of course when it landed on master. I'm preparing the revert here: https://rbcommons.com/s/twitter/r/4390/

 





 
On November 17th, 2016, 8:22 p.m. MST, John Sirois wrote:

 

  
Actually, here: https://rbcommons.com/s/twitter/r/4391/
The break was indirect.

 













(... no revert Dave!)














- John
Reply all
Reply to author
Forward
0 new messages