Review Request 4386: [IntelliJ] Use Pants to determine target list

3 views
Skip to first unread message

Yi Cheng

unread,
Nov 16, 2016, 7:56:26 PM11/16/16
to Peiyu Wang, Nick Howard (Twitter), Benjy Weinberger, Eric Ayers, Stu Hood, pants-reviews, Yi Cheng
This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4386/

Review request for pants-reviews, Benjy Weinberger, Nick Howard (Twitter), Peiyu Wang, Stu Hood, and Eric Ayers.
By Yi Cheng.
Bugs: 218
Repository: intellij-pants-plugin

Description 

Previously IntelliJ looks into the selected BUILD file to determine the targets during GUI import, which is not ideal especially since default target name is now optional.


This change make the plugin call Pants instead for target info and prompts a progress bar while getting the target list.


Other minor changes:


    

  • Rename Tempfile -> TempFile
    • 

  • Add one more check for Metrics whether it is enabled
    •

Testing 

https://travis-ci.org/pantsbuild/intellij-pants-plugin/builds/176562850

Diffs

  • common/com/twitter/intellij/pants/PantsBundle.properties (6fe9aed405f4229d167462e6e1411b5f5bf424ec)
  • common/com/twitter/intellij/pants/model/SimpleExportResult.java (3d91efaeae631b1d5e5e3f07b9691500326b22de)
  • common/com/twitter/intellij/pants/util/PantsConstants.java (effc506894780d3f386e8f06997dad197f83a9d3)
  • common/com/twitter/intellij/pants/util/PantsUtil.java (b65e837d0e73c19876cab618cbcbd861b49eb23b)
  • common/com/twitter/intellij/pants/util/Tempfile.java (7d21c9f83d676a3127ad969aae825af84d1d59e0)
  • src/com/twitter/intellij/pants/components/impl/PantsMetrics.java (4f9108280add270dfd68b7f8a467fc0a207dc35a)
  • src/com/twitter/intellij/pants/settings/PantsProjectSettingsControl.java (83571d71c8de210d46e868ce02112c5390a1c19b)
  • tests/com/twitter/intellij/pants/integration/OSSProjectInfoResolveTest.java (88a4bc80e4ec1571c7928d31f602c1a17d3efab8)

View Diff

Stu Hood

unread,
Nov 17, 2016, 1:38:56 PM11/17/16
to Peiyu Wang, Nick Howard (Twitter), Benjy Weinberger, Eric Ayers, Stu Hood, pants-reviews, Yi Cheng
This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4386/

Ship it! 

Ship It!

- Stu Hood


On November 17th, 2016, 12:56 a.m. UTC, Yi Cheng wrote:

Review request for pants-reviews, Benjy Weinberger, Nick Howard (Twitter), Peiyu Wang, Stu Hood, and Eric Ayers.
By Yi Cheng.

Updated Nov. 17, 2016, 12:56 a.m.

Reply all
Reply to author
Forward
0 new messages