Review Request 4370: Wire up native binary deploy to bintray.

0 views
Skip to first unread message

John Sirois

unread,
Nov 12, 2016, 12:57:05 AM11/12/16
to Stu Hood, Kris Wilson, pants-reviews, John Sirois
This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4370/

Review request for pants-reviews, Kris Wilson and Stu Hood.
By John Sirois.
Bugs: 4035, 4048
Repository: pants

Description

This switches to an explicit matrix that mixes in 1 osx shard and a
deploy to bintray step to effect pre-publishing native engine binaries
for green master commits as well as green stable deploy branch commits.

 .gitignore                                     |   4 +
 .travis.yml                                    | 411 +++++++++++++++++++++++++++++++++++++++++---------
 build-support/bin/generate-bintray-manifest.sh |  65 ++++++++
 3 files changed, 409 insertions(+), 71 deletions(-)

Testing

Variants of CI here have gone green:
  https://travis-ci.org/pantsbuild/pants/builds/175264324

They do not actually exercise the travis deploy step though, so
submitting TBR to see if that works.

Diffs

  • .gitignore (10d47923d8f297c8bbaa19c30fa93e0fc4d16611)
  • .travis.yml (e1bb7a1d63d0e79415958700cc87e92ce062c00c)
  • build-support/bin/generate-bintray-manifest.sh (PRE-CREATION)

View Diff

John Sirois

unread,
Nov 12, 2016, 1:59:23 AM11/12/16
to Stu Hood, Kris Wilson, pants-reviews, John Sirois
This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4370/

Reiterating this was submitted TBR.
It broke master CI and an un-reviewed follow-up was submitted to get master green: https://github.com/pantsbuild/pants/commit/3ac4f100fd0f296238131d2c0e94be21a04e2686

I'll email pants-committers with a quick summary of these activities in case the need arises to diagnose CI issues or revert.
To be clear, as things stand though, master CI is green with these changes in.

- John Sirois


On November 11th, 2016, 10:57 p.m. MST, John Sirois wrote:

Review request for pants-reviews, Kris Wilson and Stu Hood.
By John Sirois.

Updated Nov. 11, 2016, 10:57 p.m.

Reply all
Reply to author
Forward
0 new messages