Review Request 4383: Prepare the 1.3.0dev1 release.

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4383/

Review request for pants-reviews, Chris Heisterkamp, Kris Wilson, Mateo Rodriguez, and Stu Hood. By John Sirois. Bugs: 4062 Repository: pants Description CONTRIBUTORS.md | 8 ++- src/python/pants/notes/master.rst | 167 ++++++++++++++++++++++++++++++++++++++++++++++++++ src/python/pants/version.py | 2 +- 3 files changed, 173 insertions(+), 4 deletions(-) Testing I tested the ability of a release to consume the native engine binary from bintray via: $ ./build-support/bin/release.sh -n $ virtualenv -p python2.7 /tmp/pants $ source /tmp/pants/bin/activate $ pip install -f dist/ pantsbuild.pants==1.3.0dev1 $ mkdir /tmp/repo $ cd /tmp/repo $ touch pants pants.ini $ pants --enable-v2-engine list :: ... INFO] Attempting to fetch native-engine binary from: https://dl.bintray.com/pantsbuild/bin/build-support/bin/native-engine/linux/x86_64/27e0016cfd490ba89830d6e99c93764c4357c268/native-engine ... 100% .................................................. 3961 KB 3.332s INFO] Fetched native-engine binary from: https://dl.bintray.com/pantsbuild/bin/build-support/bin/native-engine/linux/x86_64/27e0016cfd490ba89830d6e99c93764c4357c268/native-engine . ... CI is away here: https://travis-ci.org/pantsbuild/pants/builds/176468919 Diffs CONTRIBUTORS.md (4c42e2b97c967cd7717af3995e97356c09c8602f) src/python/pants/notes/master.rst (25baa7878758ae8eb93de678cff81466a5d30d85) src/python/pants/version.py (19cf96aff6f73707ea72982429daf8f8daa3d855) View Diff

[Stu Hood]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4383/

Ship it!

Thanks a lot for everything you did to prep this!

CONTRIBUTORS.md (Diff revision 1)
88	+ Matt Dee	89	+ Matt Dee
		90	+ Matthew Jeffryes
89	+ Matt Landis	91	+ Matt Landis
90	+ Matt Olsen	92	+ Matt Olsen

...funky...? Not a huge deal, but I don't see how this will be stable.

- Stu Hood

On November 16th, 2016, 6:51 p.m. UTC, John Sirois wrote:

Review request for pants-reviews, Chris Heisterkamp, Kris Wilson, Mateo Rodriguez, and Stu Hood. By John Sirois.

Updated Nov. 16, 2016, 6:51 p.m.

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4383/

On November 16th, 2016, 11:58 a.m. MST, Stu Hood wrote:

CONTRIBUTORS.md (Diff revision 1)
88	+ Matt Dee	89	+ Matt Dee
		90	+ Matthew Jeffryes
89	+ Matt Landis	91	+ Matt Landis
90	+ Matt Olsen	92	+ Matt Olsen

...funky...? Not a huge deal, but I don't see how this will be stable.

Yeah, I have no clue.  Its powered by sort in build-support/bin/contributors.sh and I have:
$ locale | grep -i collate
LC_COLLATE="en_US.UTF-8"


I'm going to leave as-is for now, favoring machine generated over hand curated, but agreed it would be good to somehow ensure collations are consistent.

- John

On November 16th, 2016, 11:51 a.m. MST, John Sirois wrote:

Review request for pants-reviews, Chris Heisterkamp, Kris Wilson, Mateo Rodriguez, and Stu Hood. By John Sirois.

Updated Nov. 16, 2016, 11:51 a.m.

[Mateo Rodriguez]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4383/

Ship it!

I have concerns about shipping the node change in 85174866852aa1387cb34a7cdfd1f6642b6480c4, but it doesn't affect Foursquare. https://github.com/pantsbuild/pants/issues/4051
I will reach out to @yic about what we should do in advance of Friday release. Thanks for getting this out, John.

- Mateo Rodriguez

On November 16th, 2016, 12:51 p.m. CST, John Sirois wrote:

Review request for pants-reviews, Chris Heisterkamp, Kris Wilson, Mateo Rodriguez, and Stu Hood. By John Sirois.

Updated Nov. 16, 2016, 12:51 p.m.

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4383/

Review request for pants-reviews, Chris Heisterkamp, Kris Wilson, Mateo Rodriguez, and Stu Hood. By John Sirois.

Updated Nov. 16, 2016, 2:21 p.m. Changes Add in Nick's commit. src/python/pants/notes/master.rst | 3 +++ 1 file changed, 3 insertions(+)

Bugs: 4062 Repository: pants Description CONTRIBUTORS.md | 8 ++- src/python/pants/notes/master.rst | 167 ++++++++++++++++++++++++++++++++++++++++++++++++++ src/python/pants/version.py | 2 +- 3 files changed, 173 insertions(+), 4 deletions(-)

Testing (updated)

I tested the ability of a release to consume the native engine binary from bintray via: $ ./build-support/bin/release.sh -n $ virtualenv -p python2.7 /tmp/pants $ source /tmp/pants/bin/activate $ pip install -f dist/ pantsbuild.pants==1.3.0dev1 $ mkdir /tmp/repo $ cd /tmp/repo $ touch pants pants.ini $ pants --enable-v2-engine list :: ... INFO] Attempting to fetch native-engine binary from: https://dl.bintray.com/pantsbuild/bin/build-support/bin/native-engine/linux/x86_64/27e0016cfd490ba89830d6e99c93764c4357c268/native-engine ... 100% .................................................. 3961 KB 3.332s INFO] Fetched native-engine binary from: https://dl.bintray.com/pantsbuild/bin/build-support/bin/native-engine/linux/x86_64/27e0016cfd490ba89830d6e99c93764c4357c268/native-engine . ...

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/176468919 Diffs (updated)

CONTRIBUTORS.md (4c42e2b97c967cd7717af3995e97356c09c8602f) src/python/pants/notes/master.rst (25baa7878758ae8eb93de678cff81466a5d30d85) src/python/pants/version.py (19cf96aff6f73707ea72982429daf8f8daa3d855) View Diff

Show Changes