Review Request 4389: [IntelliJ] Fix import on directory

0 views

Skip to first unread message

Yi Cheng

unread,

Nov 17, 2016, 8:55:51 PM11/17/16

to Peiyu Wang, Stu Hood, Benjy Weinberger, Eric Ayers, Mateo Rodriguez, pants-reviews, Yi Cheng

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4389/

Review request for pants-reviews, Benjy Weinberger, Mateo Rodriguez, Peiyu Wang, Stu Hood, and Eric Ayers.

By Yi Cheng.

Repository: intellij-pants-plugin

Description

Earler https://rbcommons.com/s/twitter/r/4386 removed the usage of com.twitter.intellij.pants.util.PantsUtil#convertToTargetSpecs which implicitly convert an empty target spec (in the case where user chooses a directory instead of a specifc target) to <selected folder>::. This RB makes the directory case explicit as one of the GUI options.

Other fix: * Target in GUI will show up correctly as a/b/c:: instead of Optional[a/b/c::]

Testing

https://travis-ci.org/pantsbuild/intellij-pants-plugin/builds/176898711

Diffs

common/com/twitter/intellij/pants/util/PantsUtil.java (b65e837d0e73c19876cab618cbcbd861b49eb23b)
src/com/twitter/intellij/pants/settings/PantsProjectSettingsControl.java (83571d71c8de210d46e868ce02112c5390a1c19b)

View Diff