Review Request 4371: Add support for publishing for OSX 10.7+.

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4371/

Review request for pants-reviews, Kris Wilson, Stu Hood, and Yi Cheng. By John Sirois. Bugs: 4035, 4049 Repository: pants Description Since rust targets 10.7+ we can publish binaries for all these versions. See: https://doc.rust-lang.org/book/getting-started.html#tier-1 .travis.yml | 56 +++++++++++++++++----------------- build-support/bin/generate-bintray-manifest.sh | 65 --------------------------------------- build-support/{bootstrap_native => bin/native/bootstrap.sh} | 28 ++++++----------- build-support/bin/native/detect_os.sh | 26 ++++++++++++++++ build-support/bin/native/generate-bintray-manifest.sh | 83 ++++++++++++++++++++++++++++++++++++++++++++++++++ pants | 2 +- 6 files changed, 147 insertions(+), 113 deletions(-) Testing CI is away here: https://travis-ci.org/pantsbuild/pants/builds/175411715 Diffs .travis.yml (cb28e1fc37446080245a4afee6fe1a8f746fdf55) build-support/bin/generate-bintray-manifest.sh (b1cc7a88a2e0fa3300014a6b8e867b848bb17242) build-support/bin/native/detect_os.sh (PRE-CREATION) build-support/bin/native/generate-bintray-manifest.sh (PRE-CREATION) build-support/bootstrap_native (46fcc1a61b74cc5068ca28b0a8905090d7d06d19) pants (6a238adc38481b8935c448646a6a61b9369ef756) View Diff

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4371/

Review request for pants-reviews, Kris Wilson, Stu Hood, and Yi Cheng. By John Sirois.

Updated Nov. 12, 2016, 8:03 p.m.

Bugs: 4035, 4049 Repository: pants Description Since rust targets 10.7+ we can publish binaries for all these versions. See: https://doc.rust-lang.org/book/getting-started.html#tier-1 .travis.yml | 56 +++++++++++++++++----------------- build-support/bin/generate-bintray-manifest.sh | 65 --------------------------------------- build-support/{bootstrap_native => bin/native/bootstrap.sh} | 28 ++++++----------- build-support/bin/native/detect_os.sh | 26 ++++++++++++++++ build-support/bin/native/generate-bintray-manifest.sh | 83 ++++++++++++++++++++++++++++++++++++++++++++++++++ pants | 2 +- 6 files changed, 147 insertions(+), 113 deletions(-)

Testing (updated) CI went green here: https://travis-ci.org/pantsbuild/pants/builds/175411715

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4371/

I'm going to submit TBR and be ready to revert - this is more stuff that only actually gets exercised when it hits master.

- John Sirois

On November 12th, 2016, 8:03 p.m. MST, John Sirois wrote:

Review request for pants-reviews, Kris Wilson, Stu Hood, and Yi Cheng. By John Sirois. Updated Nov. 12, 2016, 8:03 p.m. Bugs: 4035, 4049 Repository: pants Description Since rust targets 10.7+ we can publish binaries for all these versions. See: https://doc.rust-lang.org/book/getting-started.html#tier-1 .travis.yml | 56 +++++++++++++++++----------------- build-support/bin/generate-bintray-manifest.sh | 65 --------------------------------------- build-support/{bootstrap_native => bin/native/bootstrap.sh} | 28 ++++++----------- build-support/bin/native/detect_os.sh | 26 ++++++++++++++++ build-support/bin/native/generate-bintray-manifest.sh | 83 ++++++++++++++++++++++++++++++++++++++++++++++++++ pants | 2 +- 6 files changed, 147 insertions(+), 113 deletions(-) Testing

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/175411715

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4371/

NB: I fast-followed with https://github.com/pantsbuild/pants/commit/30e034ba04d0977a101089c2f5b4162c1ed91915 directly on master to get this working for real.  Although this RB's commit did not break CI, it also did not publish binaries for mac 10.7->10.12 either!
That fast-follow though _did_ break master and so I fast-followed again with https://github.com/pantsbuild/pants/commit/4e40a16bf0b405cf54369fa338ac385130c08e12, and then https://github.com/pantsbuild/pants/commit/64c6ef5d0549ae77f3153698600530fc06843370 and finally https://github.com/pantsbuild/pants/commit/877bd0e1b10c5b84a819a88d2d2885474857833b.

You get what you deserve.

- John Sirois

On November 12th, 2016, 8:03 p.m. MST, John Sirois wrote:

Review request for pants-reviews, Kris Wilson, Stu Hood, and Yi Cheng. By John Sirois. Updated Nov. 12, 2016, 8:03 p.m. Bugs: 4035, 4049 Repository: pants Description Since rust targets 10.7+ we can publish binaries for all these versions. See: https://doc.rust-lang.org/book/getting-started.html#tier-1 .travis.yml | 56 +++++++++++++++++----------------- build-support/bin/generate-bintray-manifest.sh | 65 --------------------------------------- build-support/{bootstrap_native => bin/native/bootstrap.sh} | 28 ++++++----------- build-support/bin/native/detect_os.sh | 26 ++++++++++++++++ build-support/bin/native/generate-bintray-manifest.sh | 83 ++++++++++++++++++++++++++++++++++++++++++++++++++ pants | 2 +- 6 files changed, 147 insertions(+), 113 deletions(-) Testing

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/175411715