Review Request 4373: Generate 32 bit native engine binaries.

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4373/

Review request for pants-reviews, Kris Wilson, Stu Hood, and Yi Cheng. By John Sirois. Bugs: 4035, 4050 Repository: pants Description build-support/bin/native/bootstrap.sh | 44 +++++++++++++++++++++++++++++++++++--------- build-support/bin/native/generate-bintray-manifest.sh | 17 +++++++++++------ 2 files changed, 46 insertions(+), 15 deletions(-) Testing Locally tested both ./pants bootstrapping with no native binary and ./build-support/bin/native/generate-bintray-manifest.sh which generates a valid native-engine.bintray.json that points to valid 32 bit and 64 bit linux binaries. CI is away here: https://travis-ci.org/pantsbuild/pants/builds/175608201 Diffs build-support/bin/native/bootstrap.sh (9a3244ccb6ca558f334ca31f2c948b07c25123b2) build-support/bin/native/generate-bintray-manifest.sh (0165e4c7f576f4abd22e557281972518628d4b14) View Diff

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4373/

Review request for pants-reviews, Kris Wilson, Stu Hood, and Yi Cheng. By John Sirois.

Updated Nov. 13, 2016, 10:19 p.m.

Bugs: 4035, 4050 Repository: pants Description build-support/bin/native/bootstrap.sh | 44 +++++++++++++++++++++++++++++++++++--------- build-support/bin/native/generate-bintray-manifest.sh | 17 +++++++++++------ 2 files changed, 46 insertions(+), 15 deletions(-)

Testing (updated)

Locally tested both ./pants bootstrapping with no native binary and ./build-support/bin/native/generate-bintray-manifest.sh which generates a valid native-engine.bintray.json that points to valid 32 bit and 64 bit linux binaries.

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/175608201

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4373/

Submitting TBR to see if this actually works and deploys a 32 bit binary on master.

- John Sirois

On November 13th, 2016, 10:19 p.m. MST, John Sirois wrote:

Review request for pants-reviews, Kris Wilson, Stu Hood, and Yi Cheng. By John Sirois. Updated Nov. 13, 2016, 10:19 p.m. Bugs: 4035, 4050 Repository: pants Description build-support/bin/native/bootstrap.sh | 44 +++++++++++++++++++++++++++++++++++--------- build-support/bin/native/generate-bintray-manifest.sh | 17 +++++++++++------ 2 files changed, 46 insertions(+), 15 deletions(-) Testing

Locally tested both ./pants bootstrapping with no native binary and ./build-support/bin/native/generate-bintray-manifest.sh which generates a valid native-engine.bintray.json that points to valid 32 bit and 64 bit linux binaries.

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/175608201

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4373/

Noting I reverted this in https://github.com/pantsbuild/pants/commit/23f05de3ba6f8c08dfbb9035ceeed48953110fa0

The travis-ci Linux nodes will need gcc-multilib to be able to compile rust to a 32 bit target.

- John Sirois

On November 13th, 2016, 10:19 p.m. MST, John Sirois wrote:

Review request for pants-reviews, Kris Wilson, Stu Hood, and Yi Cheng. By John Sirois. Updated Nov. 13, 2016, 10:19 p.m. Bugs: 4035, 4050 Repository: pants Description build-support/bin/native/bootstrap.sh | 44 +++++++++++++++++++++++++++++++++++--------- build-support/bin/native/generate-bintray-manifest.sh | 17 +++++++++++------ 2 files changed, 46 insertions(+), 15 deletions(-) Testing

Locally tested both ./pants bootstrapping with no native binary and ./build-support/bin/native/generate-bintray-manifest.sh which generates a valid native-engine.bintray.json that points to valid 32 bit and 64 bit linux binaries.

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/175608201