Review Request 4380: Revert "Revert "Generate 32 bit native engine binaries.""

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4380/

Review request for pants-reviews, Mateo Rodriguez and Stu Hood. By John Sirois. Bugs: 4035, 4057 Repository: pants Description This reverts commit 23f05de3ba6f8c08dfbb9035ceeed48953110fa0. In addition, `gcc-multilib` is installed in the Travis-CI linux shards to enable cross-compiling a 32 bit native-engine binary on those nodes. .travis.yml | 22 +++++++++++----------- build-support/bin/native/bootstrap.sh | 44 +++++++++++++++++++++++++++++++++++--------- build-support/bin/native/generate-bintray-manifest.sh | 17 +++++++++++------ 3 files changed, 57 insertions(+), 26 deletions(-) Testing Verified gcc-multilib was sufficient to get 32 bit cross-compiling working with: docker run -t --rm -v $PWD/src/rust:/tmp ubuntu:trusty /bin/bash -c ' apt-get update && \ apt-get install -y curl gcc-multilib && \ curl https://sh.rustup.rs -sSf > /tmp/rustup && \ sh /tmp/rustup -y && \ ~/.cargo/bin/rustup target add i686-unknown-linux-gnu && \ ~/.cargo/bin/cargo build \ --target i686-unknown-linux-gnu \ --manifest-path /tmp/engine/Cargo.toml' CI is away here: https://travis-ci.org/pantsbuild/pants/builds/176263891 Diffs .travis.yml (56e2346e8ac7160c463a8edcb9e9efd7c6b88b9d) build-support/bin/native/bootstrap.sh (9a3244ccb6ca558f334ca31f2c948b07c25123b2) build-support/bin/native/generate-bintray-manifest.sh (0165e4c7f576f4abd22e557281972518628d4b14) View Diff

[Mateo Rodriguez]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4380/

Ship it!

Initial Docker patches officially in flight :)

- Mateo Rodriguez

On November 15th, 2016, 9:59 p.m. CST, John Sirois wrote:

Review request for pants-reviews, Kris Wilson, Mateo Rodriguez, and Stu Hood. By John Sirois. Updated Nov. 15, 2016, 9:59 p.m.

[John Sirois]

This is an automatically generated e-mail. To reply, visit: https://rbcommons.com/s/twitter/r/4380/

Review request for pants-reviews, Kris Wilson, Mateo Rodriguez, and Stu Hood. By John Sirois.

Updated Nov. 15, 2016, 9:20 p.m.

Bugs: 4035, 4057 Repository: pants Description This reverts commit 23f05de3ba6f8c08dfbb9035ceeed48953110fa0. In addition, `gcc-multilib` is installed in the Travis-CI linux shards to enable cross-compiling a 32 bit native-engine binary on those nodes. .travis.yml | 22 +++++++++++----------- build-support/bin/native/bootstrap.sh | 44 +++++++++++++++++++++++++++++++++++--------- build-support/bin/native/generate-bintray-manifest.sh | 17 +++++++++++------ 3 files changed, 57 insertions(+), 26 deletions(-)

Testing (updated)

Verified gcc-multilib was sufficient to get 32 bit cross-compiling working with: docker run -t --rm -v $PWD/src/rust:/tmp ubuntu:trusty /bin/bash -c ' apt-get update && \ apt-get install -y curl gcc-multilib && \ curl https://sh.rustup.rs -sSf > /tmp/rustup && \ sh /tmp/rustup -y && \ ~/.cargo/bin/rustup target add i686-unknown-linux-gnu && \ ~/.cargo/bin/cargo build \ --target i686-unknown-linux-gnu \ --manifest-path /tmp/engine/Cargo.toml'

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/176263891