how to assign a github issue?

Jin Feng

unread,

Oct 8, 2014, 3:10:59 PM10/8/14

to pants-devel

hi folks,

can't believe I'm asking this :)

but seems I can't assign https://github.com/pantsbuild/pants/issues/647 to myself. One other engineer reported the similar problem. Anything wrong with my/his account permission?

Thanks

Jin Feng

Tejal Desai

unread,

Oct 8, 2014, 3:13:01 PM10/8/14

to Jin Feng, pants-devel

Hmm,

time to add you to the committers list?

Do you have more than 10 commits?

Thanks
Tejal

John Sirois

unread,

Oct 8, 2014, 3:15:29 PM10/8/14

to Jin Feng, pants-devel

I _think_ you need write-access to the repo, which we've restricted on the basis of push rights to folks with 10 patches or more. I just added you to an experimental perm group to see if issue assignment can be decoupled from push rights. My guess is it cannot though.

David Turner

unread,

Oct 8, 2014, 3:17:05 PM10/8/14

to Tejal Desai, Jin Feng, pants-devel

I don't have access to that page, but I do have more than ten commits
-- could I be added to the committers? Thanks.

On Wed, Oct 8, 2014 at 3:13 PM, 'Tejal Desai' via Pants Developers

Larry Hosken

unread,

Oct 8, 2014, 3:22:17 PM10/8/14

to David Turner, Tejal Desai, Jin Feng, pants-devel

Interestingly, https://github.com/pantsbuild/pants/graphs/contributors
only shows one commit. I wonder if we trusted that when figuring out
who to include. I know I've been trusting it so far.... until you
pointed this out.

On Wed, Oct 8, 2014 at 12:17 PM, 'David Turner' via Pants Developers

John Sirois

unread,

Oct 8, 2014, 3:26:06 PM10/8/14

to Larry Hosken, David Turner, Tejal Desai, Jin Feng, pants-devel

That's an email association problem:

$ git log | grep -i david | grep turner

Author: David Turner <dtu...@twopensource.com>

Author: David Turner <dtu...@twitter.com>

David _should_ be able to associate both emails with his github account. If done post-facto I think you need to contact github support to get data re-generated. Eric had to do something like this.

I know I lost a massive amount of contributions according to github when my twitter.com email went away. The git log though is the source of truth.

Jin Feng

unread,

Oct 8, 2014, 3:28:49 PM10/8/14

to John Sirois, pants-devel

nope. still can't. but mystery understood now. and it's not a big deal.

Thanks

Jin Feng

John Sirois

unread,

Oct 8, 2014, 3:32:25 PM10/8/14

to Jin Feng, pants-devel

Aha - but I was able to add you just now. This sort-of makes sense, you're now a team-member, but you don't have rights to edit, so a team member needs to assign to you. I'll fix-up the group name and re-invite you.

John Sirois

unread,

Oct 8, 2014, 3:34:50 PM10/8/14

to Jin Feng, pants-devel

OK - the team is now called 'Contributors' and by being added to this team, although you can't push commits or branches to origin, you can be assigned issues.

David Turner

unread,

Oct 8, 2014, 3:36:04 PM10/8/14

to John Sirois, Larry Hosken, Tejal Desai, Jin Feng, pants-devel

Associated; emailed support. Thanks.

Reply all

Reply to author

Forward