thrift execution task in pangool necessary?

3 views
Skip to first unread message

Jay Vyas

unread,
Nov 9, 2012, 7:25:12 AM11/9/12
to pangoo...@googlegroups.com
Hi guys:   

- There is  a thrift plugin execution in the maven pom.xml for pangool/core, however, it doesn't seem necessary (line 268 in pangool/core/pom.xml).  

- Could this it be safely removed from the build ?  It seems yes - I deleted the entire plugin task and ran "mvn install" and it worked fine.

Pere Ferrera

unread,
Nov 9, 2012, 10:56:15 AM11/9/12
to pangoo...@googlegroups.com
There are tests for Thrift so probably that was used to generate Thrift classes to test with (test/com.datasalt.pangool.thrift.test). I think we want to have it so if we want to add more tests or generate new classes we can use it.
Reply all
Reply to author
Forward
0 new messages