reviews
Thomas Vander Stichele
I think it's a good idea that we want to have reviews before
merging/committing. Shall we get started doing that ?
1/ I see the setuptools import that I can merge. Shall I go ahead ?
2/ I have two pull requests that I just commented on that someone else
might want to look at. Takers ?
3/ Going through mails for some things is slow - I'll be sitting in
#paisley on freenode for a while in case that's something that works for
you guys, and I can definitely always be found in #twisted as
thomasvs/homeasvs/thomastp
4/ I can set up a buildbot for paisley, if that helps?
5/ I was thinking of running pychecker on paisley - since I currenty
comaintain pychecker. Any fors or againsts ?
In the meantime I've been working on my cache rewrite and added a change
listener that can invalidate the cache as well. I'll let you guys know
when I have both the simple doc cacher as well as the object mapping
cache working using the new ideas.
Thanks
Thomas
--
--
No pet names while I'm pouting.
--
Moovida - future TV today !
http://www.moovida.com/
Thomas Vander Stichele
> Hey everyone,
>
> I think it's a good idea that we want to have reviews before
> merging/committing. Shall we get started doing that ?
>
> 1/ I see the setuptools import that I can merge. Shall I go ahead ?
I did this.
> 2/ I have two pull requests that I just commented on that someone else
> might want to look at. Takers ?
Still waiting. I think doing reviews before commits is great, but
obviously it only works if people are reasonably responsive to do
reviews.
I'll just sit it out a few more days, but at some point I'm likely to
start committing the first few things.
Thomas
--
--
The future is already here.
It's just unequally distributed.
--
Flumotion - the only way to stream!
http://www.flumotion.net/
Jason J. W. Williams
I saw this. I'll try and do a review tonight. Thanks for being
patient. Are these the pulls for the object-based API?
-J
> --
> You received this message because you are subscribed to the Google Groups "Paisley" group.
> To post to this group, send email to paisley-d...@googlegroups.com.
> To unsubscribe from this group, send email to paisley-develop...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/paisley-developers?hl=en.
>
>
Thomas Vander Stichele
> Hi Thomas,
>
> I saw this. I'll try and do a review tonight. Thanks for being
> patient. Are these the pulls for the object-based API?
Hi Jason,
indeed.
I just saw that Marek Kowalski did a review of them. Let me know what
you think as well, and I'll adapt to the consensus.
It would be great to get this one in because it culls everything that
was still on launchpad, and because the launchpad and github versions
have conflicting file moves it's making my life hard for my feature
branches.
Thanks
Thomas
--
--
The not of you is unbearable.
--
URGent, best radio on the net - 24/7 !
http://urgent.fm/