epoll test cases outdated?

[Paolo Abeni]

Hello,

Using current https://github.com/google/packetdrill.git. I'm observing a bunch of tests failures on top of current -net tree:

---

#  ./packetdrill/run_all.py -lvS tcp/epoll/
OK   [/root/packetdrill/gtests/net/tcp/epoll/epoll_in_edge.pkt (ipv4)]
OK   [/root/packetdrill/gtests/net/tcp/epoll/epoll_in_edge.pkt (ipv6)]
FAIL [/root/packetdrill/gtests/net/tcp/epoll/epoll_out_edge.pkt (ipv4-mapped-v6)]
stdout:
stderr:
epoll_out_edge.pkt:41: runtime error in epoll_wait call: Expected result 0 but got 1 with errno 2 (No such file or directory)
FAIL [/root/packetdrill/gtests/net/tcp/epoll/epoll_out_edge_default_notsent_lowat.pkt (ipv4)]
stdout:
stderr:
epoll_out_edge_default_notsent_lowat.pkt:42: runtime error in epoll_wait call: Expected result 0 but got 1 with errno 2 (No such file or directory)
FAIL [/root/packetdrill/gtests/net/tcp/epoll/epoll_out_edge_default_notsent_lowat.pkt (ipv6)]
stdout:
stderr:
epoll_out_edge_default_notsent_lowat.pkt:42: runtime error in epoll_wait call: Expected result 0 but got 1 with errno 2 (No such file or directory)
FAIL [/root/packetdrill/gtests/net/tcp/epoll/epoll_out_edge_notsent_lowat.pkt (ipv4-mapped-v6)]
stdout:
stderr:
epoll_out_edge_notsent_lowat.pkt:41: runtime error in epoll_wait call: Expected result 0 but got 1 with errno 2 (No such file or directory)
OK   [/root/packetdrill/gtests/net/tcp/epoll/epoll_in_edge.pkt (ipv4-mapped-v6)]
FAIL [/root/packetdrill/gtests/net/tcp/epoll/epoll_out_edge.pkt (ipv6)]
stdout:
stderr:
epoll_out_edge.pkt:41: runtime error in epoll_wait call: Expected result 0 but got 1 with errno 2 (No such file or directory)
FAIL [/root/packetdrill/gtests/net/tcp/epoll/epoll_out_edge_notsent_lowat.pkt (ipv4)]
stdout:
stderr:
epoll_out_edge_notsent_lowat.pkt:41: runtime error in epoll_wait call: Expected result 0 but got 1 with errno 2 (No such file or directory)
FAIL [/root/packetdrill/gtests/net/tcp/epoll/epoll_out_edge.pkt (ipv4)]
stdout:
stderr:
epoll_out_edge.pkt:41: runtime error in epoll_wait call: Expected result 0 but got 1 with errno 2 (No such file or directory)
FAIL [/root/packetdrill/gtests/net/tcp/epoll/epoll_out_edge_notsent_lowat.pkt (ipv6)]
stdout:
stderr:
epoll_out_edge_notsent_lowat.pkt:41: runtime error in epoll_wait call: Expected result 0 but got 1 with errno 2 (No such file or directory)
FAIL [/root/packetdrill/gtests/net/tcp/epoll/epoll_out_edge_default_notsent_lowat.pkt (ipv4-mapped-v6)]
stdout:
stderr:
epoll_out_edge_default_notsent_lowat.pkt:42: runtime error in epoll_wait call: Expected result 0 but got 1 with errno 2 (No such file or directory)
Ran   12 tests:    3 passing,    9 failing,    0 timed out (6.08 sec): tcp/epoll/

---

Reverting the kernel commit 4bfe744ff164 ("tcp: fix potential xmit stalls caused by TCP_NOTSENT_LOWAT") solves the issues. A quick inspection of the failing epoll_wait() shows that the expected results really depend on the mentioned kernel commit presence in the running kernel.

IIRC it was mentioned a few times on the netdev ML that some later (post 4bfe744ff164) TCP fix passed all the pktdrill tests, so I'm wondering if the packetdrill github repository is outdated?!?

Thanks!

Paolo