Re: [PATCH packetdrill 1/2] net-test: packetdrill: Support AccECN counters through tcpi

[Neal Cardwell]

On Mon, Jan 19, 2026 at 1:55 PM <chia-y...@nokia-bell-labs.com> wrote:
>
> From: Ilpo Järvinen <i...@kernel.org>
>
> Add AccECN counters within tcp_info including tcpi_received_ce,
> tcpi_delivered_e1_bytes, tcpi_delivered_e0_bytes, tcpi_delivered_ce_bytes,
> tcpi_received_e1_bytes, tcpi_received_e0_bytes, tcpi_received_ce_bytes.
>
> Signed-off-by: Ilpo Järvinen <i...@kernel.org>
> Co-developed-by: Chia-Yu Chang <chia-y...@nokia-bell-labs.com>
> Signed-off-by: Chia-Yu Chang <chia-y...@nokia-bell-labs.com>
> ---
> gtests/net/packetdrill/code.c | 13 +++++++++++++
> gtests/net/packetdrill/tcp.h | 8 ++++++++
> 2 files changed, 21 insertions(+)
>
> diff --git a/gtests/net/packetdrill/code.c b/gtests/net/packetdrill/code.c
> index 68b9db2c73db..7254fe4a4a0a 100644
> --- a/gtests/net/packetdrill/code.c
> +++ b/gtests/net/packetdrill/code.c
> @@ -207,6 +207,19 @@ static void write_tcp_info(struct code_state *code,
> emit_var(code, "tcpi_total_rto", info->tcpi_total_rto);
> emit_var(code, "tcpi_total_rto_recoveries", info->tcpi_total_rto_recoveries);
> emit_var(code, "tcpi_total_rto_time", info->tcpi_total_rto_time);
> + emit_var(code, "tcpi_received_ce", info->tcpi_received_ce);
> + emit_var(code, "tcpi_delivered_e1_bytes",
> + info->tcpi_delivered_e1_bytes);
> + emit_var(code, "tcpi_delivered_e0_bytes",
> + info->tcpi_delivered_e0_bytes);
> + emit_var(code, "tcpi_delivered_ce_bytes",
> + info->tcpi_delivered_ce_bytes);
> + emit_var(code, "tcpi_received_e1_bytes",
> + info->tcpi_received_e1_bytes);
> + emit_var(code, "tcpi_received_e0_bytes",
> + info->tcpi_received_e0_bytes);
> + emit_var(code, "tcpi_received_ce_bytes",
> + info->tcpi_received_ce_bytes);
>
> emit_var_end(code);
> }
> diff --git a/gtests/net/packetdrill/tcp.h b/gtests/net/packetdrill/tcp.h
> index 328911738613..12a4d11ebcf2 100644
> --- a/gtests/net/packetdrill/tcp.h
> +++ b/gtests/net/packetdrill/tcp.h
> @@ -243,6 +243,14 @@ struct _tcp_info {
> * in milliseconds, including any
> * unfinished recovery.
> */
> + __u32 tcpi_received_ce; /* # of CE marks received */
> + __u32 tcpi_delivered_e1_bytes; /* Accurate ECN byte counters */
> + __u32 tcpi_delivered_e0_bytes;
> + __u32 tcpi_delivered_ce_bytes;
> + __u32 tcpi_received_e1_bytes;
> + __u32 tcpi_received_e0_bytes;
> + __u32 tcpi_received_ce_bytes;
> +
> };
>
> /* netlink attributes types for SCM_TIMESTAMPING_OPT_STATS */
> --
> 2.34.1

Merged as the following commit:

https://github.com/google/packetdrill/commit/efedb2868bd2b2e5f63338ef101ac93f191508e6

neal