Documentation website has same title

[Eugen Stan]

Hello,

The documentation title is hardcoded to be <title>pac4j: security for
Java</title> .

This makes for a very poor experience when bookmarking and reading via
apps like Pocket, Wallabag (works with KOReader - to read on eReader).

I have marked a few articles in the docs to read them on my eReader and
I can't tell which one is which - since they are all named "pac4j:
security for Java"

https://github.com/pac4j/pac4j/blob/master/documentation/_includes/header.html

I think using somethinge like:
<title>{{ page.title }}</title> or {{ post.title }}

or use an if to test for both:
https://shopify.github.io/liquid/tags/control-flow/

<title>
{% if page.title %}
{{ page.title }}
{% else %}
{{ post.title }}
{% endif %}
</title>

(Did not test any of the above).


https://jekyllrb.com/docs/layouts/

Regards,
Eugen

[Jérôme LELEU]

Hi,

I took a slightly different option, but titles should be more relevant now.

Thanks.

Best regards,

Jérôme

--
You received this message because you are subscribed to the Google Groups "Pac4j development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pac4j-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/pac4j-dev/6518e4b6-3c1c-44d1-947f-8a01322b347d%40gmail.com.

[Eugen Stan]

Hi,

Thank you.
It's good enough for me.
I refetched content and titles updated.
Unfortunatelly, KOReader did not update the artilces on my eReader. \
Will see if this is a bug or a feature on that side.

Thanks,
Eugen

p.s. I am working on this https://github.com/ieugen/pac4clj , not ready
for yet. I hope to have it done for a first review in the next week or so.

La 27.08.2024 11:03, Jérôme LELEU a scris:
> Hi,
>
> I took a slightly different option, but titles should be more relevant now.
> Thanks.
> Best regards,
> Jérôme
>
>
> Le lun. 26 août 2024 à 17:35, Eugen Stan <stan....@gmail.com

> <mailto:stan....@gmail.com>> a écrit :

>
> Hello,
>
> The documentation title is hardcoded to be  <title>pac4j: security for
> Java</title> .
>
> This makes for a very poor experience when bookmarking and reading via
> apps like Pocket, Wallabag (works with KOReader - to read on eReader).
>
> I have marked a few articles in the docs to read them on my eReader and
> I can't tell which one is which - since they are all named "pac4j:
> security for Java"
>
> https://github.com/pac4j/pac4j/blob/master/documentation/_includes/

> header.html <https://github.com/pac4j/pac4j/blob/master/
> documentation/_includes/header.html>

>
> I think using somethinge like:
> <title>{{ page.title }}</title> or {{ post.title }}
>
> or use an if to test for both:

> https://shopify.github.io/liquid/tags/control-flow/ <https://
> shopify.github.io/liquid/tags/control-flow/>

>
> <title>
> {% if page.title %}
>     {{ page.title }}
> {% else %}
>     {{ post.title }}
> {% endif %}
> </title>
>
> (Did not test any of the above).
>
>

> https://jekyllrb.com/docs/layouts/ <https://jekyllrb.com/docs/layouts/>

>
> Regards,
> Eugen
>
> --
> You received this message because you are subscribed to the Google
> Groups "Pac4j development mailing list" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to pac4j-dev+...@googlegroups.com

> <mailto:pac4j-dev%2Bunsu...@googlegroups.com>.

> To view this discussion on the web visit https://groups.google.com/
> d/msgid/pac4j-dev/6518e4b6-3c1c-44d1-947f-8a01322b347d%40gmail.com

> <https://groups.google.com/d/msgid/pac4j-
> dev/6518e4b6-3c1c-44d1-947f-8a01322b347d%40gmail.com>.
>