SAML2Client ignores forceReinit in some functions

[Ádám Csiszár]

Hello.

I noticed that some init functions in the SAML2Client indirectly ignores the forceReinit parameter.

For example, the initAuthenticator function checks if the authenticator is null or the forceReinit parameter is true, then calls the setAuthenticatorIfUndefined which checks if the authenticator is null.

Thus, if the authenticator is not null but forceReinit is true, then the authenticator will not be set again.

Not sure if this is a bug or a feature.

[Jérôme LELEU]

Hi,

Yes, the check on forceReinit is a bit strange, but I guess it's necessary.

It's a recent change made by @mmoayyed: Misagh, do you confirm this is done on purpose?

Thanks.

Best regards,

Jérôme

--
You received this message because you are subscribed to the Google Groups "Pac4j development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pac4j-dev+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/pac4j-dev/93563e3c-408b-4907-b956-1607b428775fn%40googlegroups.com.