libm symbol

[zhiting zhu]

Hey,

I want to use ffmpeg python binding(pyav) in osv. One of the dependencies, libx264 uses __log2f_finite which is from libm. In the compiled lib, it shows that: U __log2_finite@@GLIBC_2.15
I see the symbol is implemented in libc/math/aliases.c.  On the host, the symbol is provided by libm. What should I do to make the symbol resolved on osv?

Best,

Zhiting

[zhiting zhu]

Maybe I'm looking at the screen too long. I miss the f. The provided on is log2_finite.

[Waldek Kozaczuk]

We just need to add it __log2f_finite in a similar way we added __log2_finite. Should be trivial change.

diff --git a/libc/math/aliases.c b/libc/math/aliases.c

index 361f3cf7..b137d530 100644

--- a/libc/math/aliases.c

+++ b/libc/math/aliases.c

@@ -20,6 +20,11 @@ double __log2_finite(double x)

        return log2(x);

 }

 

+double __log2f_finite(double x)

+{

+       return log2f(x);

+}

+

 double __log_finite(double x)

 {

        return log(x);

BTW which ffmpeg version are you using?

Waldek

[zhiting zhu]

I'm using 4.0.4.