[COMMIT osv master] blk_ioctl: address the review suggestion

1 view
Skip to first unread message

Commit Bot

unread,
Jun 28, 2024, 5:10:05 PM (5 days ago) Jun 28
to osv...@googlegroups.com, Waldemar Kozaczuk
From: Waldemar Kozaczuk <jwkoz...@gmail.com>
Committer: Waldemar Kozaczuk <jwkoz...@gmail.com>
Branch: master

blk_ioctl: address the review suggestion

Signed-off-by: Waldemar Kozaczuk <jwkoz...@gmail.com>

---
diff --git a/drivers/blk-common.cc b/drivers/blk-common.cc
--- a/drivers/blk-common.cc
+++ b/drivers/blk-common.cc
@@ -18,11 +18,6 @@

TRACEPOINT(trace_blk_ioctl, "dev=%s type=%#x nr=%d size=%d, dir=%d", char*, int, int, int, int);

-static void no_bio_done(bio* b)
-{
- delete b;
-}
-
int
blk_ioctl(struct device* dev, u_long io_cmd, void* buf)
{
@@ -41,7 +36,7 @@ blk_ioctl(struct device* dev, u_long io_cmd, void* buf)
{
auto* bio = alloc_bio();
bio->bio_dev = dev;
- bio->bio_done = no_bio_done;
+ bio->bio_done = destroy_bio;
bio->bio_cmd = BIO_FLUSH;

dev->driver->devops->strategy(bio);
Reply all
Reply to author
Forward
0 new messages