Calendar Tests in Repo

[Bruce Trask]

Hello,

I am running the calendar tests.  Are the expected-base and expected-full txt files in sync with the tests.  I am not seeing ADDEVENT anywhere in the models anymore but it is in the expected files.

Thanks in advance.

Bruce

[Teemu Kanstrén]

Which calendar tests do you mean? The ones in the examples repository? I have not actually been updating the tests in that package for a long time but rather tried to keep the examples running and working reasonably. I would recommend to have a look rather at the actual examples src directory for some models, try running those, modify, and see how the output changes etc. 

I should probably remove those tests from the repo, actually, thanks for pointing that out.

--
You received this message because you are subscribed to the Google Groups "osmo" group.
To unsubscribe from this group and stop receiving emails from it, send an email to osmo-mbt+u...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Bruce Trask]

Hi Teemu,

Thanks for your reply.

The test model I am looking at is:

package osmo.tester.examples.calendar.testmodel.CalendarMeetingModel;

which is used by:

package osmo.tester.examples.calendar.CalendarTests;

CalendarTests has test such as:

 @Test
  public void baseModelOnline() {
    ModelState state = new ModelState();
    CalendarScripter scripter = new OnlineScripter();
    SingleInstanceModelFactory factory = new SingleInstanceModelFactory();
    osmo.setModelFactory(factory);
    factory.add(new CalendarMeetingModel(state, scripter, out));
    generateAndAssertOutput("expected-base-online.txt");
    scripter.write();
  }

The referenced "expected-base-online.txt" file does not contain the strings output by the CalendarMeetingModel.  Just wanted to find out if the expected
test files were in sync with the test models.  Thought I might be missing something here, since I do not see any ADDMEETINGS in the txt file.

Thanks in advance.

Regards,
Bruce

[Bruce Trask]

Oh and I forgot to give the location of the txt file that I am referring to.  It is at:
hg/examples/ test/osmo/tester/examples/calendar/expected-base-online.txt

[Teemu Kanstrén]

Hi,

 Yes this is one of the old unit tests for the example package. I originally intended to have these verify that the examples are still working as intended when I make changes. Obviously most of the time I forgot these tests as they are separate from the main code, and so they have been out of synch for a long time. I mostly just update the source tree for the examples every now and then, mostly if I am considering creating a package of it. In those cases I try to run them and observe the results make sense and it works. But you are correct those tests are not up to date. Actually, when I tried to run them with the latest code it just produced errors.

 I also removed them now from my repo to avoid further confusion in the future. The main code source tree has lots of similar tests running if you are interested in something like that.

Cheers,

Teemu

--

[Bruce Trask]

Hi Teemu,

Thanks for your fast reply. Thanks for clarifying that and I understand.  No problem.  I will have a look at the other similar tests in the main code source tree.

Regards,
Bruce