CMake stuff

24 views
Skip to first unread message

Paul Martz

unread,
Nov 8, 2011, 6:03:32 PM11/8/11
to osgbull...@googlegroups.com
Well, it seems like most of the CMake dbl prec auto-detection is working now,
for several test cases. Anyone care to do an update and try it again?

--
-Paul Martz Skew Matrix Software
http://www.skew-matrix.com/

Karrot

unread,
Nov 9, 2011, 3:39:33 AM11/9/11
to osgbullet-users
*cleans up environment again for fresh builds* :)

Juan Sebastián Casallas

unread,
Nov 9, 2011, 8:27:07 AM11/9/11
to osgbull...@googlegroups.com
I've found a test case that doesn't work, it may be a corner case, though:

I have two bullet installations, say one for testing and one that's stable. The stable one is on the default path and has DOUBLE_PRECISION and the other doesn't.

The first time I generate the osgBullet cmake, it detects the stable installation and outputs:


"Bullet double precision detected. Automatically defining BT_USE_DOUBLE_PRECISION for osgBullet."


However, I want to use my bullet test installation, which doesn't have DOUBLE_PRECISION, so I change from "Default Installation" to "Alternative Install Location", regenerate and then enter the adequate path on "BulletInstallLocation", I regenerate and get:


"Bullet single precision detected. Not defining BT_USE_DOUBLE_PRECISION for osgBullet."


However, the BT_USE_DOUBLE_PRECISION box is still checked.


I tested with cmake 2.6 both on Mac OS X 10.6.8 (Snow Leopard) and Windows XP and got the same results


----------------------

Juan Sebastian 


On Wed, Nov 9, 2011 at 9:39 AM, Karrot <dennis.c...@gmail.com> wrote:
*cleans up environment again for fresh builds* :)

--
You received this message because you are subscribed to the Google Groups "osgbullet-users" group.
To post to this group, send email to osgbull...@googlegroups.com.
To unsubscribe from this group, send email to osgbullet-use...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/osgbullet-users?hl=en.


Karrot

unread,
Nov 9, 2011, 8:32:36 AM11/9/11
to osgbullet-users
Ah, right, Just needs a forced uncheck if double precision is not
found then.

ie.

===================================================================
--- CMakeModules/FindBulletHelper.cmake (revision 281)
+++ CMakeModules/FindBulletHelper.cmake (working copy)
@@ -205,6 +205,7 @@
)
if( _result )
message( STATUS "Bullet single precision detected. Not
defining BT_USE_DOUBLE_PRECISION for osgBullet." )
+ set( OSGBULLET_USE_DOUBLE_PRECISION OFF CACHE BOOL ""
FORCE )
else()
message( WARNING "Unable to determine single or double
precision. Contact development staff." )
message( "Build output follows:" )

(not tested, but should work.. (asumption is the m..))

Add the set(.. line in your findbullet, delete your cache and try the
same sequence again.

Juan Sebastián Casallas

unread,
Nov 9, 2011, 8:51:58 AM11/9/11
to osgbull...@googlegroups.com
I've attached a small patch that fixes this issue, I've tested it on Snow Leopard and Windows XP.

Juan Sebastian

2011/11/9 Juan Sebastián Casallas <juan.s....@gmail.com>
FindBulletHelper.cmake.patch

Juan Sebastián Casallas

unread,
Nov 9, 2011, 8:59:38 AM11/9/11
to osgbull...@googlegroups.com
Oh sorry, I hadn't seen this (darn gmail pop polling frequency...), it's the same as the patch I've sent and tested.

Karrot

unread,
Nov 9, 2011, 9:03:54 AM11/9/11
to osgbullet-users
Haha, no problem, I just posted it as plain text since the
googlegroups doesn't allow for attachments (or I just haven't found
out how).

Eitherway Paul can just import that patch then.

Paul Martz

unread,
Nov 9, 2011, 9:36:14 AM11/9/11
to osgbull...@googlegroups.com
Thanks, guys! This is now committed.
   -Paul
Reply all
Reply to author
Forward
0 new messages