C++ bindings need some work

[Caitlin Potter]

This is what I've got so far -- https://github.com/caitp/webvtt/tree/c++-bindings

It won't build with autotools/gcc on my system (For some reason libtool isn't giving the -I directives to gcc? but that doesn't make sense to me .v.)

In any case, a lot more work is needed for it I think. Also interesting is, for whatever reason, MSVC2010 seems to build it just fine.

[Caitlin Potter]

After some work, I've gotten it to build with both msvc and autotools

This required some changes to the public C headers and a little bit of the API, so... any other language bindings and gtest stuff needs to be looked at.

It does need some significant review, so by all means, test

[Richard Eyre]

Just some questions:

https://github.com/caitp/webvtt/blob/c%2B%2B-bindings/src/libwebvtt/cuetext.c#L224 - I thought we agreed we wouldn't do this

https://github.com/caitp/webvtt/blob/c%2B%2B-bindings/src/libwebvtt/string.h#L79 - Why are we ! twice here? Only thing I can think of is that you want to be absolutely certain that it come outs to a 0 or 1. 

You're going to have to explain a lot of the changes to the string class to me as now I dunno whats going on. Why this https://github.com/caitp/webvtt/blob/c%2B%2B-bindings/src/libwebvtt/string.c#L63 ? this https://github.com/caitp/webvtt/blob/c%2B%2B-bindings/src/libwebvtt/string.c#L115 ? etc.

Why is webvtt_string now a pointer to a string? https://github.com/caitp/webvtt/blob/c%2B%2B-bindings/include/webvtt/string.h#L32 

I'm sure you've had reasons to do this, I just need clarification on the purpose if I'm going to write tests for this. 

On Tuesday, November 20, 2012 2:23:36 AM UTC-5, Caitlin Potter wrote:

[Richard Eyre]

I see the purpose of string_detach now that I've looked at it a little bit more. This solves one of the problems I was thinking about before.

[Caitlin Potter]

There is an issue with our Travis build selecting only a C compiler. The project now contains C++ code as well, so, we should have Travis build each section with its appropriate code.

(Is that possible??)

Maybe we need to add something to configure.ac to provide that