Contribution - Use default encoding when specific character set value is invalid

Tristan Cheever

unread,

May 12, 2020, 10:53:17 PM5/12/20

to Orthanc Users

Hi,

I'm presenting a potential contribution. The patch is attached.

Currently, Orthanc defaults to ASCII encoding when the specific character set value is invalid. We have encountered health systems which have invalid specific character set values but the encoding is UTF-8 (ISO_IR 192). The patch changes the behavior such that Orthanc will use the DefaultEncoding parameter from the configuration file. This provides the flexibility needed to handle such scenarios.

I understand that the patch is a backwards-incompatible change. Perhaps another configuration parameter is needed to specify if this is the desired behavior in order to maintain backwards-compatibility.

As a new member to this group, I have the following questions:

Is there a reason for the ASCII default when the specific character set value is invalid?
Do any of the appropriate reviewers find this flexibility valuable? It would enable Orthanc at health systems with this predicament.
Are there other suggestions for backwards-compatibility that are more idiomatic for this codebase?

Regards,

Tristan

contribution.patch

Alain Mazy

unread,

May 19, 2020, 10:24:06 AM5/19/20

to Tristan Cheever, Orthanc Users

Hi Tristan,

I just want to acknowledge that we've received your contribution and want to thank you for that !

As you mention, it might break backward compatibility so we need to analyse this quite in details.

We're quite busy with the 1.7.0 release and we'll probably look at this change a bit later.

Best regards,

Alain.

--
You received this message because you are subscribed to the Google Groups "Orthanc Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to orthanc-user...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/orthanc-users/3a53cbe6-fd70-44fb-acc1-91a8cce66639%40googlegroups.com.

--

Alain Mazy / Orthanc-Studio Manager & Software Developer
a...@osimis.io / +32 494 31 67 27

OSIMIS S.A.
Quai Banning 6BE-4000 Liège
www.osimis.io

Tristan Cheever

unread,

Jun 9, 2020, 3:48:40 PM6/9/20

to Orthanc Users

Hi Alain,

Congratulations on getting 1.7.0 out the door. I look forward to checking out the enhancements.

Have you or your team had a chance to consider the contribution?

Regards,

Tristan

On Tuesday, May 19, 2020 at 7:24:06 AM UTC-7, Alain Mazy wrote:

Hi Tristan,

I just want to acknowledge that we've received your contribution and want to thank you for that !

As you mention, it might break backward compatibility so we need to analyse this quite in details.
We're quite busy with the 1.7.0 release and we'll probably look at this change a bit later.

Best regards,

Alain.

On Wed, May 13, 2020 at 4:53 AM Tristan Cheever <tri...@ferrumhealth.com> wrote:

Hi,

I'm presenting a potential contribution. The patch is attached.

Currently, Orthanc defaults to ASCII encoding when the specific character set value is invalid. We have encountered health systems which have invalid specific character set values but the encoding is UTF-8 (ISO_IR 192). The patch changes the behavior such that Orthanc will use the DefaultEncoding parameter from the configuration file. This provides the flexibility needed to handle such scenarios.

I understand that the patch is a backwards-incompatible change. Perhaps another configuration parameter is needed to specify if this is the desired behavior in order to maintain backwards-compatibility.

As a new member to this group, I have the following questions:
Is there a reason for the ASCII default when the specific character set value is invalid?
Do any of the appropriate reviewers find this flexibility valuable? It would enable Orthanc at health systems with this predicament.
Are there other suggestions for backwards-compatibility that are more idiomatic for this codebase?
Regards,
Tristan

--
You received this message because you are subscribed to the Google Groups "Orthanc Users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to orthan...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/orthanc-users/3a53cbe6-fd70-44fb-acc1-91a8cce66639%40googlegroups.com.

Sébastien Jodogne

unread,

Jun 10, 2020, 7:30:13 AM6/10/20

to Orthanc Users

Dear Tristan,

Sorry for the delay, we are still extremely busy until the beginning of July.

Be sure that we appreciate your contribution, and that we'll carefully review it as soon as possible.

Kind Regards,

Sébastien-

Sébastien Jodogne

unread,

Aug 14, 2020, 3:20:00 AM8/14/20

to Orthanc Users

Dear Tristan,

Sorry for the delay. In order to better understand your proposal and to work on our test suite, please could you provide us with sample DICOM files?

Regards,

Sébastien-

Tristan Cheever

unread,

Aug 14, 2020, 6:29:41 PM8/14/20

to Sébastien Jodogne, Orthanc Users

Hi Sébastien,

Sure, I will attempt to recreate the problem we saw without using the health system data and provide spoof DICOM files (compliance). It may be a while before I have the bandwidth for this but will get it to you as soon as possible.

Regards,

Tristan

--

You received this message because you are subscribed to the Google Groups "Orthanc Users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to orthanc-user...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/orthanc-users/52a1788a-147e-41bb-b4b6-d167d856c57an%40googlegroups.com.

Reply all

Reply to author

Forward