A great start! ... and it could still be improved

0 views
Skip to first unread message

Henning

unread,
May 30, 2008, 4:33:44 AM5/30/08
to orapig-dev
Hello orapig-dev users,

first of all a big "thank you" to Mark!
This is great work. I always thought about implementing something like
this myself, but never found the time to do so...

I added some of my ideas to the issues section at the google code
page. Alas, this was before I found this discussion list... Then, at
least for the PL/SQL record problem, I found that this is discussed
here already.

Unfortunately, it seems I cannot change the type or priority of the
issues I added. They are listed as "defects", but of course they
aren't defects.

Should the issues be discussed inside this group or commented on the
corresponding issue entries?

I'm willing to contribute code, at least for the comment style issue.

Henning

Mark Roddy

unread,
May 30, 2008, 10:43:10 AM5/30/08
to orapi...@googlegroups.com
Henning,
I added a patch to the AS vs. IS issue issue on the google code site.

Mark,
Can you take a look at the patch? It's a small modification of the
'asline' re declaration in the Trans.getdoc() function.

-Mark

Mark Harrison

unread,
May 30, 2008, 1:34:01 PM5/30/08
to orapi...@googlegroups.com, h.von...@gmail.com
Henning wrote:
> Hello orapig-dev users,
>
> first of all a big "thank you" to Mark!
> This is great work. I always thought about implementing something like
> this myself, but never found the time to do so...
>
> I added some of my ideas to the issues section at the google code
> page. Alas, this was before I found this discussion list... Then, at
> least for the PL/SQL record problem, I found that this is discussed
> here already.
>
> Unfortunately, it seems I cannot change the type or priority of the
> issues I added. They are listed as "defects", but of course they
> aren't defects.
>
> Should the issues be discussed inside this group or commented on the
> corresponding issue entries?

Probably in this group... at least for me, it will catch my attention
sooner. I'm trying to figure out how to send email notification
on issue creation, but I'm not seeing it. It seems that the google
issue tracker is pretty new.

>
> I'm willing to contribute code, at least for the comment style issue.


That's great, send it along to this list.

Welcome aboard!
Mark

Mark Harrison

unread,
May 30, 2008, 1:47:57 PM5/30/08
to orapi...@googlegroups.com, h.von...@gmail.com
Mark Roddy wrote:
> Henning,
> I added a patch to the AS vs. IS issue issue on the google code site.
>
> Mark,
> Can you take a look at the patch? It's a small modification of the
> 'asline' re declaration in the Trans.getdoc() function.

Looks good, I changed it up a bit to take advantage of the
ignore case flag in the re package:

+ asline=re.compile(r'^[\s]*(AS|IS)[\s]*$',re.IGNORECASE)

I'll push it out in a little while...

Thanks!


PS, Henning, my mail to h.von...@gmail.com was bouncing, I'll
try sending again...

mar...@gmail.com

unread,
May 31, 2008, 3:16:39 AM5/31/08
to orapig-dev


On May 30, 10:34 am, Mark Harrison <m...@pixar.com> wrote:
> Probably in this group... at least for me, it will catch my attention
> sooner. I'm trying to figure out how to send email notification
> on issue creation, but I'm not seeing it. It seems that the google
> issue tracker is pretty new.

Well I figured out three things today:

- to get the status, priority, etc menu options, click in the
description box. I'm sure somebody at google thinks this
is an obvious and clever thing to do.

- to set priority, etc, use the labels at the bottom of the screen.

- it's not a good idea to have a typo in the group email field.

Now that I'm such a google code expert, the issue tracker seems
pretty nice... let's go ahead and use it. I'll enter in anything
that's
in the list now, so be prepared for mucho-deleto.

Mark
Reply all
Reply to author
Forward
0 new messages