[PATCH 0/3] Remove unnecessary 'out of memory' message

506 views
Skip to first unread message

Kumari Radha

unread,
Oct 3, 2014, 10:54:46 AM10/3/14
to opw-k...@googlegroups.com
The following patchset removes unnecessay out of memory messages fixing the following checkpach.pl warning:
WARNING: Possible unnecessary 'out of memory' message

Kumari Radha (3):
staging: gs_fpgaboot: Remove unnecessary 'out of memory' message
staging: media: omap24xx: Remove unnecessary 'out of memory' message
staging: media: omap4iss: Remove unnecessary 'out of memory' message

drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 4 +---
drivers/staging/media/omap24xx/omap24xxcam.c | 4 +---
drivers/staging/media/omap4iss/iss.c | 4 +---
3 files changed, 3 insertions(+), 9 deletions(-)

--
1.7.9.5

Kumari Radha

unread,
Oct 3, 2014, 10:55:21 AM10/3/14
to opw-k...@googlegroups.com
This patch removes unnecessay out of memory message in gs_fpgaboot.c fixing the following checkpach.pl warning:
WARNING: Possible unnecessary 'out of memory' message

Signed-off-by: Kumari Radha <kumari...@gmail.com>
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
index 6aa9d7c..1875bd3 100644
--- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
+++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
@@ -316,10 +316,8 @@ static int gs_fpgaboot(void)
struct fpgaimage *fimage;

fimage = kmalloc(sizeof(struct fpgaimage), GFP_KERNEL);
- if (fimage == NULL) {
- pr_err("No memory is available\n");
+ if (fimage == NULL)
goto err_out;
- }

err = gs_load_image(fimage, file);
if (err) {
--
1.7.9.5

Kumari Radha

unread,
Oct 3, 2014, 10:56:15 AM10/3/14
to opw-k...@googlegroups.com
This patch removes unnecessay out of memory message fixing the following checkpach.pl warning in omap24xxcam.c:
WARNING: Possible unnecessary 'out of memory' message

Signed-off-by: Kumari Radha <kumari...@gmail.com>
---
drivers/staging/media/omap24xx/omap24xxcam.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/media/omap24xx/omap24xxcam.c b/drivers/staging/media/omap24xx/omap24xxcam.c
index d2b440c..8edf187 100644
--- a/drivers/staging/media/omap24xx/omap24xxcam.c
+++ b/drivers/staging/media/omap24xx/omap24xxcam.c
@@ -1743,10 +1743,8 @@ static int omap24xxcam_probe(struct platform_device *pdev)
int irq;

cam = kzalloc(sizeof(*cam), GFP_KERNEL);
- if (!cam) {
- dev_err(&pdev->dev, "could not allocate memory\n");
+ if (!cam)
goto err;
- }

platform_set_drvdata(pdev, cam);

--
1.7.9.5

Kumari Radha

unread,
Oct 3, 2014, 10:57:19 AM10/3/14
to opw-k...@googlegroups.com
This patch removes unnecessay out of memory message fixing the following checkpach.pl warning in iss.c:
WARNING: Possible unnecessary 'out of memory' message

Signed-off-by: Kumari Radha <kumari...@gmail.com>
---
drivers/staging/media/omap4iss/iss.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
index d548371..6e9e869 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -1357,10 +1357,8 @@ static int iss_probe(struct platform_device *pdev)
return -EINVAL;

iss = devm_kzalloc(&pdev->dev, sizeof(*iss), GFP_KERNEL);
- if (!iss) {
- dev_err(&pdev->dev, "Could not allocate memory\n");
+ if (!iss)
return -ENOMEM;
- }

mutex_init(&iss->iss_mutex);

--
1.7.9.5

Greg KH

unread,
Oct 7, 2014, 8:37:37 PM10/7/14
to Kumari Radha, opw-k...@googlegroups.com
Someone else sent this right before you did, sorry.

greg k-h

Kumari Radha

unread,
Oct 8, 2014, 3:14:21 AM10/8/14
to opw-k...@googlegroups.com, kumari...@gmail.com
The following patchset removes unnecessay out of memory messages fixing the following checkpach.pl warning:
WARNING: Possible unnecessary 'out of memory' message

Kumari Radha (2):
staging: media: omap24xx: Remove unnecessary 'out of memory' message
staging: media: omap4iss: Remove unnecessary 'out of memory' message

drivers/staging/media/omap24xx/omap24xxcam.c | 4 +---
drivers/staging/media/omap4iss/iss.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)

--
1.7.9.5

Kumari Radha

unread,
Oct 8, 2014, 3:15:05 AM10/8/14
to opw-k...@googlegroups.com, kumari...@gmail.com
This patch removes unnecessay out of memory message fixing the following checkpach.pl warning in omap24xxcam.c:
WARNING: Possible unnecessary 'out of memory' message

Signed-off-by: Kumari Radha <kumari...@gmail.com>
---
drivers/staging/media/omap24xx/omap24xxcam.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

Kumari Radha

unread,
Oct 8, 2014, 3:15:51 AM10/8/14
to opw-k...@googlegroups.com, kumari...@gmail.com
This patch removes unnecessay out of memory message fixing the following checkpach.pl warning in iss.c:
WARNING: Possible unnecessary 'out of memory' message

Signed-off-by: Kumari Radha <kumari...@gmail.com>
---
drivers/staging/media/omap4iss/iss.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

Josh Triplett

unread,
Oct 8, 2014, 3:21:27 AM10/8/14
to Kumari Radha, opw-k...@googlegroups.com
On Wed, Oct 08, 2014 at 12:44:57PM +0530, Kumari Radha wrote:
> This patch removes unnecessay out of memory message fixing the following checkpach.pl warning in omap24xxcam.c:
> WARNING: Possible unnecessary 'out of memory' message
>
> Signed-off-by: Kumari Radha <kumari...@gmail.com>

Reviewed-by: Josh Triplett <jo...@joshtriplett.org>

> drivers/staging/media/omap24xx/omap24xxcam.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/omap24xx/omap24xxcam.c b/drivers/staging/media/omap24xx/omap24xxcam.c
> index d2b440c..8edf187 100644
> --- a/drivers/staging/media/omap24xx/omap24xxcam.c
> +++ b/drivers/staging/media/omap24xx/omap24xxcam.c
> @@ -1743,10 +1743,8 @@ static int omap24xxcam_probe(struct platform_device *pdev)
> int irq;
>
> cam = kzalloc(sizeof(*cam), GFP_KERNEL);
> - if (!cam) {
> - dev_err(&pdev->dev, "could not allocate memory\n");
> + if (!cam)
> goto err;
> - }
>
> platform_set_drvdata(pdev, cam);
>
> --
> 1.7.9.5
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Josh Triplett

unread,
Oct 8, 2014, 3:21:43 AM10/8/14
to Kumari Radha, opw-k...@googlegroups.com
On Wed, Oct 08, 2014 at 12:45:44PM +0530, Kumari Radha wrote:
> This patch removes unnecessay out of memory message fixing the following checkpach.pl warning in iss.c:
> WARNING: Possible unnecessary 'out of memory' message
>
> Signed-off-by: Kumari Radha <kumari...@gmail.com>

Reviewed-by: Josh Triplett <jo...@joshtriplett.org>

> drivers/staging/media/omap4iss/iss.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
> index d548371..6e9e869 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -1357,10 +1357,8 @@ static int iss_probe(struct platform_device *pdev)
> return -EINVAL;
>
> iss = devm_kzalloc(&pdev->dev, sizeof(*iss), GFP_KERNEL);
> - if (!iss) {
> - dev_err(&pdev->dev, "Could not allocate memory\n");
> + if (!iss)
> return -ENOMEM;
> - }
>
> mutex_init(&iss->iss_mutex);
>
> --
> 1.7.9.5
>
Reply all
Reply to author
Forward
0 new messages